You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/11/21 02:51:27 UTC

Review Request 63974: SENTRY-2062: Support the new Hive 2.3.2 DbNotificationListener

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63974/
-----------------------------------------------------------

Review request for sentry.


Bugs: sentry-2062
    https://issues.apache.org/jira/browse/sentry-2062


Repository: sentry


Description
-------

Switch unit-tests to use the Hive DbNotificationListener and refactor all the SentryJSON* messages to implement the HMS API instead of the HCAT API.


Diffs
-----

  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAddPartitionMessage.java 10d7a934ae27935fc446ce44cd6ade15bd527e4b 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterPartitionMessage.java 25de8083a9e62f70de638f7f35aba6e45ed6ec77 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONAlterTableMessage.java 4670494a1522a3fa61323159d0e0ddd5ee840f78 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateDatabaseMessage.java 8c627586ade1f7deeeceea47a2cea6023a90f761 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONCreateTableMessage.java d15bc48886107fe1bb944642a31704408d13cf23 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropDatabaseMessage.java c8e7c75c8f99a7af3776519544a039f880a476db 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropPartitionMessage.java d5f899c8e6948f73d2e9beb6e3552c83954d58b8 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONDropTableMessage.java e67f56243d0b08a9c9892e7a2646c44d4e58d936 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageDeserializer.java 929ac8c05f4d24044139b26b8e6bc6dc5791cc81 
  sentry-binding/sentry-binding-hive-follower/src/main/java/org/apache/sentry/binding/metastore/messaging/json/SentryJSONMessageFactory.java 0af02d1c164f482f90a839eff66f95be6ad49d55 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListener.java 11b6b4add0643999b491cd8c6e09b4efa50c10ed 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerBase.java 40cf17a470c41ac81218a0472da368aa502fac65 
  sentry-binding/sentry-binding-hive/src/main/java/org/apache/sentry/binding/metastore/SentryMetastorePostEventListenerNotificationLog.java 90502310a77d7dc6ebbeb9b1d5783c05fc2b6063 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/FullUpdateModifier.java 25019708411c66c43700f7219b4059dd31af80a3 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/NotificationProcessor.java d92f23e637769330775d00152c363529572186d1 
  sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryHMSClient.java 6ec163b1d802810287a55bc5cd98409bc73e8ba8 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/provider/db/service/persistent/TestHMSFollowerSentryStoreIntegration.java 928d0c8d861d4414bb53bf41e1c0353332381654 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestFullUpdateModifier.java 4f90c3e68f0c76e08fb590bce26e560f2b7ae1ed 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestHMSFollower.java bbcf09382d65eb99fa15df6971aea1d55d6e23b3 
  sentry-provider/sentry-provider-db/src/test/java/org/apache/sentry/service/thrift/TestNotificationProcessor.java 00f9b3959b7ccf9d046c422a007ff375eddba076 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hdfs/TestHDFSIntegrationBase.java 25a678b2bb54de386227d031b12048ab8604b47c 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/hive/AbstractTestWithStaticConfiguration.java a6e7356805b66bb43e61d25b588d8de2cb80fe8f 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestDBNotificationListenerInBuiltDeserializer.java ea44e33f17f4e226fb0af1366d2aa6d65115f5d9 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestDbNotificationListenerSentryDeserializer.java 8e588b1d954d4ed90beb464055b2fcc07c7e72c1 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerInBuiltDeserializer.java c4be62db71e67099f22f3ba8991e03a32fb0f28a 
  sentry-tests/sentry-tests-hive/src/test/java/org/apache/sentry/tests/e2e/metastore/TestSentryListenerSentryDeserializer.java 3a404dd446932e5ceb1e37fc4315d506d0e1e1fd 


Diff: https://reviews.apache.org/r/63974/diff/1/


Testing
-------


Thanks,

Sergio Pena