You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/03 05:03:16 UTC

[PR] [ISSUE #771] Provide dashboard summary from clusters [rocketmq-dashboard]

Aias00 opened a new pull request, #772:
URL: https://github.com/apache/rocketmq-dashboard/pull/772

   ## Summary
   
   - replace the production `DashboardProviderStub` with a `ClusterDashboardProvider`
   - build dashboard stats and cluster overview rows from the existing `ClusterRepository`
   - keep unknown values conservative: `totalMessagesToday` remains `0` until a real metrics source is available
   - add provider coverage for normal and empty cluster repositories
   
   Fixes #771
   
   ## Verification
   
   - `JAVA_HOME=$(/usr/libexec/java_home -v 21) mvn -Dtest=ClusterDashboardProviderTest,DashboardServiceTest,DashboardControllerTest test` from `server/`
   
   ## Notes
   
   The first test run with the shell default Java 17 failed with `release version 21 not supported`; the project requires Java 21 and passes with OpenJDK 21.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #771] Provide dashboard summary from clusters [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #772: [ISSUE #771] Provide dashboard summary from clusters
URL: https://github.com/apache/rocketmq-dashboard/pull/772


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #771] Provide dashboard summary from clusters [rocketmq-dashboard]

Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #772:
URL: https://github.com/apache/rocketmq-dashboard/pull/772#issuecomment-5175099413

   Closing as superseded by the current dashboard provider wiring. #699 removed DashboardProviderStub from Spring injection, and rocketmq-studio now provides @Primary RocketMQDashboardProvider with a deterministic empty-dashboard fallback when admin access is unavailable. Rebasing this PR would add a second non-primary provider that DashboardService does not use. Verified on current rocketmq-studio with `mvn -Dtest=DashboardServiceTest,DashboardControllerTest test` (4 tests passed).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [ISSUE #771] Provide dashboard summary from clusters [rocketmq-dashboard]

Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #772:
URL: https://github.com/apache/rocketmq-dashboard/pull/772#issuecomment-5654591397

   ⚠️ **Merge conflict detected**
   
   This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
   
   ```bash
   git fetch origin
   git checkout fix/studio-dashboard-summary-provider
   git rebase origin/main
   # resolve conflicts, then:
   git push --force-with-lease
   ```
   
   This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
   
   ---
   *Automated notification by github-manager-bot*
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org