You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "akshaychitneni (via GitHub)" <gi...@apache.org> on 2026/08/11 16:57:59 UTC
[I] Replace the advertise_flight_sql_endpoint empty-string sentinel with an explicit flag [datafusion-ballista]
akshaychitneni opened a new issue, #2281:
URL: https://github.com/apache/datafusion-ballista/issues/2281
The scheduler decides whether to start its embedded Arrow Flight proxy by matching on an empty string:
// ballista/scheduler/src/scheduler_process.rs:104
```
match &config.advertise_flight_sql_endpoint {
Some(proxy) if proxy.is_empty() => { /* start embedded flight proxy */ }
// Some("host:port") => advertise an external endpoint
// None => no proxy
}
```
So one Option<String> overloads three meanings, and Some("") = "enable the embedded proxy" is non-obvious — a config/env value that happens to be empty silently flips a mode.
Proposal: add an explicit enable_embedded_flight_proxy: bool (or an enum) separate from the "advertise this external endpoint" string, and treat an empty advertise_flight_sql_endpoint as
unset rather than as a switch.
Follow-up from [#2244 review](https://github.com/apache/datafusion-ballista/pull/2244#issuecomment-5226731477)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Replace the advertise_flight_sql_endpoint empty-string sentinel with an explicit flag [datafusion-ballista]
Posted by "andygrove (via GitHub)" <gi...@apache.org>.
andygrove closed issue #2281: Replace the advertise_flight_sql_endpoint empty-string sentinel with an explicit flag
URL: https://github.com/apache/datafusion-ballista/issues/2281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [I] Replace the advertise_flight_sql_endpoint empty-string sentinel with an explicit flag [datafusion-ballista]
Posted by "sandugood (via GitHub)" <gi...@apache.org>.
sandugood commented on issue #2281:
URL: https://github.com/apache/datafusion-ballista/issues/2281#issuecomment-5265521034
take
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org