You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "zpinto (via GitHub)" <gi...@apache.org> on 2025/01/10 05:14:17 UTC
[PR] Add jdk8 support for helix-lock module [helix]
zpinto opened a new pull request, #2988:
URL: https://github.com/apache/helix/pull/2988
### Issues
- [x] Add jdk8 support for helix-lock module
### Description
- [ ] We currently to support helix-lock jdk8, which is used by Ambry. Adding this to unblock Ambry's helix upgrade
### Tests
```
➜ helix git:(zpinto/add_jdk8_helix_lock) mvn clean install -Dmaven.test.skip.exec=true
...
[INFO] --- jar:3.3.0:jar (default-package-jdk8) @ helix-lock ---
[INFO] Building jar: /Users/zapinto/Documents/git2/zpinto/helix/helix-lock/target/helix-lock-1.4.3-SNAPSHOT-jdk8.jar
...
[INFO]
[INFO] --- bundle:5.1.4:install (default-install) @ meta-client ---
[INFO] Installing org/apache/helix/meta-client/1.4.3-SNAPSHOT/meta-client-1.4.3-SNAPSHOT.jar
[INFO] Installing org/apache/helix/meta-client/1.4.3-SNAPSHOT/meta-client-1.4.3-SNAPSHOT-jdk8.jar
[INFO] Writing OBR metadata
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for Apache Helix 1.4.3-SNAPSHOT:
[INFO]
[INFO] Apache Helix ....................................... SUCCESS [ 0.795 s]
[INFO] Apache Helix :: Metrics Common ..................... SUCCESS [ 1.989 s]
[INFO] Apache Helix :: Metadata Store Directory Common .... SUCCESS [ 1.609 s]
[INFO] Apache Helix :: ZooKeeper API ...................... SUCCESS [ 3.681 s]
[INFO] Apache Helix :: Helix Common ....................... SUCCESS [ 1.313 s]
[INFO] Apache Helix :: Core ............................... SUCCESS [ 17.335 s]
[INFO] Apache Helix :: Restful Interface .................. SUCCESS [ 2.350 s]
[INFO] Apache Helix :: Distributed Lock ................... SUCCESS [ 1.520 s]
[INFO] Apache Helix :: HelixAgent ......................... SUCCESS [ 0.496 s]
[INFO] Apache Helix :: Recipes ............................ SUCCESS [ 0.009 s]
[INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SUCCESS [ 0.347 s]
[INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SUCCESS [ 0.404 s]
[INFO] Apache Helix :: Recipes :: distributed lock manager SUCCESS [ 0.310 s]
[INFO] Apache Helix :: Recipes :: distributed task execution SUCCESS [ 0.321 s]
[INFO] Apache Helix :: Recipes :: service discovery ....... SUCCESS [ 0.337 s]
[INFO] Apache Helix :: View Aggregator .................... SUCCESS [ 0.550 s]
[INFO] Apache Helix :: Meta Client ........................ SUCCESS [ 2.557 s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 36.316 s
[INFO] Finished at: 2025-01-09T21:05:51-08:00
[INFO] ------------------------------------------------------------------------
```
### Changes that Break Backward Compatibility (Optional)
NA
### Documentation (Optional)
NA
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Add jdk8 support for helix-lock module [helix]
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu commented on PR #2988:
URL: https://github.com/apache/helix/pull/2988#issuecomment-2583576936
Should adding `maven-compiler-plugin` to helix-lock be enough? Why we are changing other components to jdk8?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Add jdk8 support for helix-lock module [helix]
Posted by "zpinto (via GitHub)" <gi...@apache.org>.
zpinto commented on PR #2988:
URL: https://github.com/apache/helix/pull/2988#issuecomment-2583897890
CI failure is due to flaky test https://github.com/apache/helix/issues/2945
This PR is ready to be merged!
Commit message:
Add jdk8 support for helix-lock module and rename jar packaging execution ids to match jdk8 and fix typos from past changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
Re: [PR] Add jdk8 support for helix-lock module [helix]
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2988:
URL: https://github.com/apache/helix/pull/2988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org