You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2021/07/18 19:41:37 UTC

[GitHub] [incubator-yunikorn-k8shim] yangwwei commented on a change in pull request #282: [YUNIKORN-754] Fix web link about build document in readme of incubator…

yangwwei commented on a change in pull request #282:
URL: https://github.com/apache/incubator-yunikorn-k8shim/pull/282#discussion_r671888082



##########
File path: README.md
##########
@@ -28,7 +28,7 @@ YuniKorn scheduler shim for kubernetes is a customized k8s scheduler, it can be
 This project contains the k8s shim layer code for k8s, it depends on `yunikorn-core` which encapsulates all the actual scheduling logic.
 By default, it handles all pods scheduling if pod's spec has field `schedulerName: yunikorn`.
 
-For detailed information on how to build the overall scheduler please see the [build document](https://github.com/apache/incubator-yunikorn-core/blob/master/docs/developer-guide.md) in the `yunikorn-core`.
+For detailed information on how to build the overall scheduler please see the [build document](https://github.com/apache/incubator-yunikorn-site/blob/master/docs/developer_guide/build.md) in the `yunikorn-site`.

Review comment:
       Can we link this to https://yunikorn.apache.org/docs/next/developer_guide/build?
   If there are any other links that link to the source code in yunikorn-site repo, we should change them to our website link




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org