[jira] [Commented] (ZOOKEEPER-2936) Duplicate Keys in log4j.properties config files

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2936?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16381358#comment-16381358 ] 

ASF GitHub Bot commented on ZOOKEEPER-2936:
-------------------------------------------

Github user asutosh936 commented on the issue:

    https://github.com/apache/zookeeper/pull/473
  
    @anmolnar - Thanks for the Review.
    
    The issue is about having duplicate keys for ROLLINGFILE layout and conversion pattern. The fix is to remove the duplicate keys from the file. As rightly said there is no reason of commenting the code, instead deleting it. Please review.


> Duplicate Keys in log4j.properties config files
> -----------------------------------------------
>
>                 Key: ZOOKEEPER-2936
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2936
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: contrib, other
>    Affects Versions: 3.4.8
>         Environment: Apache ZooKeeper source tarball
>            Reporter: Hari Sekhon
>            Priority: Trivial
>
> Recent versions of ZooKeeper have introduced the following duplicate keys in to the contrib log4j.properties files.
> In this file:
> {code}
> ./zookeeper-3.4.8/contrib/rest/conf/log4j.properties
> {code}
> and this file:
> {code}
> ./zookeeper-3.4.8/src/contrib/rest/conf/log4j.properties
> {code}
> the following duplicate keys are found:
> {code}
> log4j.appender.ROLLINGFILE.layout=org.apache.log4j.PatternLayout
> log4j.appender.ROLLINGFILE.layout.ConversionPattern=%d{ISO8601} - %-5p [%t:%C{1}@%L] - %m%n
> {code}
> This was discovered because I've written file validators for most major formats which recurse all my github repos and this was failing my integration tests when pulling ZooKeeper source code. I actually added --exclude and --ignore-duplicate-keys switches to {code}validate_ini.py{code} to work around this and fix my builds for now but just remembered to raise this to you guys.
> The validator tools if you're interested can be found at:
> https://github.com/harisekhon/pytools
> Cheers
> Hari



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)