You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flex.apache.org by Justin Mclean <ju...@classsoftware.com> on 2017/02/01 22:21:54 UTC
Re: failing tests / flash player locale issue with negative numbers
Hi,
Anyone have some free cycles to look at this? If not I'd say lets just go ahead with the release candidate. I've had several people (on and off list) ask when the next release is out.
Thanks,
Justin
Re: failing tests / flash player locale issue with negative numbers
Posted by Alex Harui <ah...@adobe.com>.
All of the tests you listed passed on my Mac. So I think we are good to
go.
-Alex
On 2/1/17, 4:15 PM, "Alex Harui" <ah...@adobe.com> wrote:
>I will try to look now. I had missed the bottom of your other reply with
>the list of failures. My brain was waiting for an attachment. I forgot
>that the list doesn't like attachments.
>
>I'm still puzzled by the DropDownList fix. To me it looks like the only
>effective change is:
>
> if (displayItem != null)
>
>
>Was replaced by:
>
> if (displayItem != null && displayItem != undefined)
>
>
>Or is there some subtle other difference I'm missing? I don't get what
>value of displayItem would behave differently in the if statement. I
>would understand if the code was using !==.
>
>-Alex
>
>On 2/1/17, 2:21 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>
>>Hi,
>>
>>Anyone have some free cycles to look at this? If not I'd say lets just go
>>ahead with the release candidate. I've had several people (on and off
>>list) ask when the next release is out.
>>
>>Thanks,
>>Justin
>
Re: failing tests / flash player locale issue with negative numbers
Posted by Alex Harui <ah...@adobe.com>.
OK, I get it now.
Thanks,
-Alex
On 2/1/17, 4:59 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>> I'm still puzzled by the DropDownList fix. To me it looks like the only
>> effective change is:
>>
>> if (displayItem != null)
>>
>>
>> Was replaced by:
>>
>> if (displayItem != null && displayItem != undefined)
>>
>>
>> Or is there some subtle other difference I'm missing?
>
>In the code before my change if display Item was undefined it would be
>set to selectedItem. In the code after my change it set to selectedItem
>and LabelUtil.itemToLabel is called. If LabelUtil.itemToLabel is not
>called the display doesn’t update. The displayItem != undefined check is
>probably not needed but it was in the original code, my change just put
>it back the way it was before it was “optimised”.
>
>Thanks,
>Justin
Re: failing tests / flash player locale issue with negative numbers
Posted by Justin Mclean <ju...@classsoftware.com>.
Hi,
> I'm still puzzled by the DropDownList fix. To me it looks like the only
> effective change is:
>
> if (displayItem != null)
>
>
> Was replaced by:
>
> if (displayItem != null && displayItem != undefined)
>
>
> Or is there some subtle other difference I'm missing?
In the code before my change if display Item was undefined it would be set to selectedItem. In the code after my change it set to selectedItem and LabelUtil.itemToLabel is called. If LabelUtil.itemToLabel is not called the display doesn’t update. The displayItem != undefined check is probably not needed but it was in the original code, my change just put it back the way it was before it was “optimised”.
Thanks,
Justin
Re: failing tests / flash player locale issue with negative numbers
Posted by Alex Harui <ah...@adobe.com>.
I will try to look now. I had missed the bottom of your other reply with
the list of failures. My brain was waiting for an attachment. I forgot
that the list doesn't like attachments.
I'm still puzzled by the DropDownList fix. To me it looks like the only
effective change is:
if (displayItem != null)
Was replaced by:
if (displayItem != null && displayItem != undefined)
Or is there some subtle other difference I'm missing? I don't get what
value of displayItem would behave differently in the if statement. I
would understand if the code was using !==.
-Alex
On 2/1/17, 2:21 PM, "Justin Mclean" <ju...@classsoftware.com> wrote:
>Hi,
>
>Anyone have some free cycles to look at this? If not I'd say lets just go
>ahead with the release candidate. I've had several people (on and off
>list) ask when the next release is out.
>
>Thanks,
>Justin