You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/19 13:05:50 UTC

Review Request 66134: ATLAS-2506 : Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66134/
-----------------------------------------------------------

Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.


Bugs: ATLAS-2506
    https://issues.apache.org/jira/browse/ATLAS-2506


Repository: atlas


Description
-------

Attributes of the filters added in the inner filter group are not added in the "attributes" parameter of the POST body.

Hence "attributes" in the POST body has only createTime , retention and not temporary.


Diffs
-----

  dashboardv2/public/js/views/search/SearchLayoutView.js a0cd41e 


Diff: https://reviews.apache.org/r/66134/diff/1/


Testing
-------

Done one round of sanity testing.


Thanks,

pratik pandey


Re: Review Request 66134: ATLAS-2506 : Attributes of filters in the inner filter group are not added to "attributes" JSON array of the Basic POST request body

Posted by Nixon Rodrigues <ni...@freestoneinfotech.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66134/#review199667
-----------------------------------------------------------


Ship it!




Ship It!

- Nixon Rodrigues


On March 19, 2018, 1:05 p.m., pratik pandey wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66134/
> -----------------------------------------------------------
> 
> (Updated March 19, 2018, 1:05 p.m.)
> 
> 
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
> 
> 
> Bugs: ATLAS-2506
>     https://issues.apache.org/jira/browse/ATLAS-2506
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Attributes of the filters added in the inner filter group are not added in the "attributes" parameter of the POST body.
> 
> Hence "attributes" in the POST body has only createTime , retention and not temporary.
> 
> 
> Diffs
> -----
> 
>   dashboardv2/public/js/views/search/SearchLayoutView.js a0cd41e 
> 
> 
> Diff: https://reviews.apache.org/r/66134/diff/1/
> 
> 
> Testing
> -------
> 
> Done one round of sanity testing.
> 
> 
> Thanks,
> 
> pratik pandey
> 
>