You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/12/12 18:37:46 UTC
[GitHub] [airflow] dhuang commented on issue #6794: [AIRFLOW-6231] Display
DAG run conf in the graph view
dhuang commented on issue #6794: [AIRFLOW-6231] Display DAG run conf in the graph view
URL: https://github.com/apache/airflow/pull/6794#issuecomment-565130713
> I like that 👍 But I am wondering if it would look better below the Graph View or between the Base Date row and the Graph View.
Good idea. I think I like it best between the Base Date and the graph so it's under where one selects the run. Below the graph seems a little too out of sight (I think generally very relevant info if one is setting `conf`), but does avoid putting the graph out of initial view if there's a large conf (although `doc_md` would have this same issue anyways). Updated, but open for feedback.
> This should not be stored/viewed in the Graph View! I am fine with having this in Details page or somwhere else
The details page is at the DAG level. Since the `conf` value is tied to a specific DagRun, I assume it should only land on a page that displays things at a per DagRun level? I think the only alternative (or perhaps show in both) is the Tree View, which I think a big `conf` blobs is too much for the DAG hover over, but maybe could put it in the modal?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services