You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2022/07/24 11:53:21 UTC

[GitHub] [lucene-jira-archive] mikemccand opened a new pull request, #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py

mikemccand opened a new pull request, #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74

   Just changed words presented to humans ;)  No actual code change for the machines.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-jira-archive] mocobeta merged pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py

Posted by GitBox <gi...@apache.org>.
mocobeta merged PR #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-jira-archive] mocobeta commented on pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py

Posted by GitBox <gi...@apache.org>.
mocobeta commented on PR #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74#issuecomment-1193314053

   I'd merge this, thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-jira-archive] mocobeta commented on a diff in pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py

Posted by GitBox <gi...@apache.org>.
mocobeta commented on code in PR #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74#discussion_r928254467


##########
migration/src/remap_cross_issue_links.py:
##########
@@ -68,11 +68,11 @@ def remap_issue_link_in_comments(issue_number: int, issue_id_map: dict[str, str]
     check_authentication(github_token)
 
     parser = argparse.ArgumentParser()
-    parser.add_argument('--issues', type=int, required=False, nargs='*', help='GitHub issue number list to be downloaded')
-    args = parser.parse_args()
-    
     mapping_data_dir = Path(__file__).resolve().parent.parent.joinpath(MAPPINGS_DATA_DIRNAME)
     issue_mapping_file = mapping_data_dir.joinpath(ISSUE_MAPPING_FILENAME)
+    parser.add_argument('--issues', type=int, required=False, nargs='*', help=f'GitHub issue number list to be downloaded, else all GitHub issues in {issue_mapping_file.relative_to(Path.cwd())}')

Review Comment:
   I copied this help string from another file. Let me adjust it.
   ```suggestion
       parser.add_argument('--issues', type=int, required=False, nargs='*', help=f'GitHub issue number list to be exported, else all GitHub issues in {issue_mapping_file.relative_to(Path.cwd())}')
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-jira-archive] mikemccand commented on pull request #74: Polish a few sharp edges that hit me when running remap_cross_issue_links.py

Posted by GitBox <gi...@apache.org>.
mikemccand commented on PR #74:
URL: https://github.com/apache/lucene-jira-archive/pull/74#issuecomment-1193835019

   Thank you @mocobeta! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org