[PR] fix: candidate controllers missing Forget call in workqueue [apisix-ingress-controller]

["Revolyssup (via GitHub)" <gi...@apache.org>]

Revolyssup opened a new pull request, #2308:
URL: https://github.com/apache/apisix-ingress-controller/pull/2308

   Users encountered the error:
   ```bash
   2024-10-02T19:24:30+08:00 [31merror[0m adapter/etcd.go:141 failed to create object, ignore it{error 26 0 rpc error: code = InvalidArgument desc = etcdserver: duplicate key given in txn request} {revision 11 625 <nil>} {key 15 0 /apisix/global_rules/c6bbeaf1 <nil>}
   ```
   This error only comes for global rule and only comes in candidate controllers.
   Reason:
   In current logic, the candidate controllers miss the .Forget() call on the successfully processed object and re-add the object in the workqueue. This fix makes sure that event is removed from the queue when object is processed successfully.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] fix: candidate controllers missing Forget call in workqueue [apisix-ingress-controller]

["Revolyssup (via GitHub)" <gi...@apache.org>]

Revolyssup merged PR #2308:
URL: https://github.com/apache/apisix-ingress-controller/pull/2308


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org