You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by okram <gi...@git.apache.org> on 2017/02/15 22:24:22 UTC

[GitHub] tinkerpop pull request #559: TINKERPOP-1627: LazyBarrierStrategy should not ...

GitHub user okram opened a pull request:

    https://github.com/apache/tinkerpop/pull/559

    TINKERPOP-1627: LazyBarrierStrategy should not append an end barrier.

    https://issues.apache.org/jira/browse/TINKERPOP-1627
    
    You don't want `LazyBarrierStrategy` appending `NoOpBarriers` to the root traversal. It was doing that because I was trying to be clever and have it consider `RemoteTraversal` I/O (via bulking). Dumb. `RemoteStrategy` should be responsible for that concern.  Fixed.
    
    VOTE +1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/tinkerpop TINKERPOP-1627

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/tinkerpop/pull/559.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #559
    
----
commit 080306b099b3ca5dbf5bf5041447fd1a0557b9cb
Author: Marko A. Rodriguez <ok...@gmail.com>
Date:   2017-02-15T22:07:53Z

    Fixed an optimization bug in LazyBarrierStrategy. RemoteStrategy should be responsible for network I/O concerns (and using bulking as the optimization).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #559: TINKERPOP-1627: LazyBarrierStrategy should not append ...

Posted by spmallette <gi...@git.apache.org>.

Github user spmallette commented on the issue:

    https://github.com/apache/tinkerpop/pull/559
  
    All tests pass with `docker/build.sh -t -n -i`
    
    VOTE +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop pull request #559: TINKERPOP-1627: LazyBarrierStrategy should not ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/tinkerpop/pull/559


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] tinkerpop issue #559: TINKERPOP-1627: LazyBarrierStrategy should not append ...

Posted by dkuppitz <gi...@git.apache.org>.

Github user dkuppitz commented on the issue:

    https://github.com/apache/tinkerpop/pull/559
  
    `docker/build.sh -t -i` succeeded.
    
    VOTE: +1


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---