[jira] [Commented] (FLINK-8921) Split code generated call expression

["Timo Walther (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-8921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17032246#comment-17032246 ] 

Timo Walther commented on FLINK-8921:
-------------------------------------

[~aljoscha] I'm not sure if this issue can be closed. It might still exist in the Blink planner. It was reported a couple of times by users. [~jark] has this been addressed in Blink code gen? Can we have big expressions for one function arg without reaching the JVM limits?

> Split code generated call expression 
> -------------------------------------
>
>                 Key: FLINK-8921
>                 URL: https://issues.apache.org/jira/browse/FLINK-8921
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Legacy Planner
>            Reporter: Timo Walther
>            Assignee: xueyu
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> In FLINK-8274 we introduced the possibility of splitting the generated code into multiple methods in order to exceed the JVMs maximum method size (see also https://docs.oracle.com/javase/specs/jvms/se7/html/jvms-4.html#jvms-4.9).
> At the moment we only split methods by fields, however, this is not enough in all case. We should also split expressions. I suggest to split the operands of a {{RexCall}} in {{org.apache.flink.table.codegen.CodeGenerator#visitCall}} if we reach a certain threshold. However, this should happen as lazily as possible to keep the runtime overhead low.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)