You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jclouds.apache.org by Adrian Cole <no...@github.com> on 2014/10/06 00:04:21 UTC
[jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
You can merge this Pull Request by running:
git pull https://github.com/adriancole/jclouds-labs adrian.vbox-no-async
Or you can view, comment on it, or merge it online at:
https://github.com/jclouds/jclouds-labs/pull/84
-- Commit Summary --
* VirtualBox was unnecessarily using a deprecated HttpAsyncClient.
-- File Changes --
M virtualbox/src/main/java/org/jclouds/virtualbox/functions/admin/FileDownloadFromURI.java (8)
-- Patch Links --
https://github.com/jclouds/jclouds-labs/pull/84.patch
https://github.com/jclouds/jclouds-labs/pull/84.diff
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #297](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/297/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57954922
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by Adrian Cole <no...@github.com>.
> @@ -59,7 +59,7 @@ public File apply(@Nullable URI input) {
> final File file = new File(isosDir, new File(input.getPath()).getName());
> try {
> if (!file.exists()) {
> - final InputStream inputStream = client.get(input).get();
facepalm
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84/files#r18437977
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by Adrian Cole <no...@github.com>.
Closed #84.
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#event-174308226
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1618](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1618/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57954739
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by Andrew Phillips <no...@github.com>.
+1, looks good to me. Thanks, @adriancole!
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57955101
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by Adrian Cole <no...@github.com>.
cherry-picked into master, 1.8.x
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57956327
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by BuildHive <no...@github.com>.
[jclouds » jclouds-labs #1619](https://buildhive.cloudbees.com/job/jclouds/job/jclouds-labs/1619/) SUCCESS
This pull request looks good
[(what's this?)](https://www.cloudbees.com/what-is-buildhive)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57955242
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by Andrew Phillips <no...@github.com>.
> @@ -59,7 +59,7 @@ public File apply(@Nullable URI input) {
> final File file = new File(isosDir, new File(input.getPath()).getName());
> try {
> if (!file.exists()) {
> - final InputStream inputStream = client.get(input).get();
Doh! ;-)
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84/files#r18438141
Re: [jclouds-labs] VirtualBox was unnecessarily using a deprecated
HttpAsyncClient. (#84)
Posted by CloudBees pull request builder plugin <no...@github.com>.
[jclouds-labs-pull-requests #298](https://jclouds.ci.cloudbees.com/job/jclouds-labs-pull-requests/298/) SUCCESS
This pull request looks good
---
Reply to this email directly or view it on GitHub:
https://github.com/jclouds/jclouds-labs/pull/84#issuecomment-57954938