You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@htrace.apache.org by "stack (JIRA)" <ji...@apache.org> on 2015/01/13 23:29:35 UTC

[jira] [Commented] (HTRACE-72) Address Billie Renaldi comments on RC6 (.gitignore clash and 'pkg' still in src tarball)

    [ https://issues.apache.org/jira/browse/HTRACE-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276090#comment-14276090 ] 

stack commented on HTRACE-72:
-----------------------------

Added this addendum on branch 3.1: i.e. mention of gorilla in our LICENSE .. it was on master, not on branch:

{code}
kalashnikov-11:incubator-htrace stack$ git show -1
commit f1f74a685230fa76b086973f5408919980cfd94d
Author: stack <st...@duboce.net>
Date:   Tue Jan 13 14:24:32 2015 -0800

    HTRACE-71 Address Billie Renaldi comments on RC6 (.gitignore clash and pkg still in src tarball) -- ADDENDUM

diff --git a/LICENSE.txt b/LICENSE.txt
index de15f01..6d7bec1 100644
--- a/LICENSE.txt
+++ b/LICENSE.txt
@@ -221,6 +221,9 @@ Bootstrap, an html, css, and javascript framework, is
 Copyright (c) 2011-2015 Twitter, Inc and MIT licensed:
 https://github.com/twbs/bootstrap/blob/master/LICENSE

+Gorilla mux gorilla/mux implements a request router and dispatcher is BSD
+licensed: https://github.com/gorilla/mux/blob/master/LICENSE
+
 godep, a build dependency is Copyright © 2013 Keith Rarick
 and portions Copyright (c) 2012 The Go Authors. Its a BSD
 license: https://github.com/tools/godep/blob/master/License
{code}

> Address Billie Renaldi comments on RC6 (.gitignore clash and 'pkg' still in src tarball)
> ----------------------------------------------------------------------------------------
>
>                 Key: HTRACE-72
>                 URL: https://issues.apache.org/jira/browse/HTRACE-72
>             Project: HTrace
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: stack
>             Fix For: 3.1.0, master
>
>
> Addressing Billie's feedback on the RC for RC6.  She found we still have binaries in the src tarball and that there was a git conflict in .gitignore.  She suggested more stuff bundled but only new is godep which is build only dependency (I added it to license anyways).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)