[GitHub] [pulsar-client-go] pgier commented on a diff in pull request #809: [issue #807] dlq topic producer options

[GitBox <gi...@apache.org>]

pgier commented on code in PR #809:
URL: https://github.com/apache/pulsar-client-go/pull/809#discussion_r923445110


##########
pulsar/dlq_router.go:
##########
@@ -135,12 +135,16 @@ func (r *dlqRouter) getProducer(schema Schema) Producer {
 	// Retry to create producer indefinitely
 	backoff := &internal.Backoff{}
 	for {
-		producer, err := r.client.CreateProducer(ProducerOptions{
-			Topic:                   r.policy.DeadLetterTopic,
-			CompressionType:         LZ4,
-			BatchingMaxPublishDelay: 100 * time.Millisecond,
-			Schema:                  schema,
-		})
+		opt := r.policy.DLQProducerOptions
+		opt.Topic = r.policy.DeadLetterTopic
+		opt.Schema = schema
+
+		// the origin code sets to LZ4 compression with no options
+		// so the new design allows compression type to be overwritten but still set lz4 by default
+		if r.policy.DLQProducerOptions.CompressionType == NoCompression {

Review Comment:
   Are there any cases where a user would want to explicitly set to NoCompression?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org