You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/12/08 17:34:53 UTC

[GitHub] [pinot] agavra commented on a diff in pull request #9912: support case-insensitive query options in SET syntax

agavra commented on code in PR #9912:
URL: https://github.com/apache/pinot/pull/9912#discussion_r1043636548


##########
pinot-common/src/main/java/org/apache/pinot/sql/parsers/CalciteSqlParser.java:
##########
@@ -171,7 +172,7 @@ static SqlNodeAndOptions extractSqlNodeAndOptions(String sql, SqlNodeList sqlNod
     if (sqlType == null) {
       throw new SqlCompilationException("SqlNode with executable statement not found!");
     }
-    return new SqlNodeAndOptions(statementNode, sqlType, options);
+    return new SqlNodeAndOptions(statementNode, sqlType, QueryOptionsUtils.resolveCaseInsensitiveOptions(options));

Review Comment:
   I considered both of these and thought it was OK to make this a partial improvement. the SET syntax is particularly misleading given that it "feels" like sql - if we feel strongly about it I can attempt to wire this in through the other places as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org