You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@commons.apache.org by garydgregory <gi...@git.apache.org> on 2016/04/13 23:17:27 UTC

[GitHub] commons-lang pull request: LANG-781 Added methods to ObjectUtils c...

Github user garydgregory commented on the pull request:

    https://github.com/apache/commons-lang/pull/108#issuecomment-209650500
  
    Yes:
    - Thank you for the patch.
    - The Javadoc has some bogus text, like starting with "<p></p>". You do not need that.
    - Do not use a for-each loop to traverse an array. This creates an iterator when none is needed. Use a normal for loop, which will not create the extra Iterator to GC. This matters when a libraries is used on the critical path and/or environments trying to do low/no GC.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---