You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/04/16 02:37:00 UTC
Review Request 33250: RANGER-278 Re-enable policy validation
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33250/
-----------------------------------------------------------
Review request for ranger and Madhan Neethiraj.
Bugs: RANGER-278
https://issues.apache.org/jira/browse/RANGER-278
Repository: ranger
Description
-------
Re-enabling policy validation that was turned off since policy query logic was WIP
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a9ade43
security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java f4534a1
security-admin/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/33250/diff/
Testing
-------
Did manual testing by excercising REST API
- Policy can be created with same name if in different service.
- Policy can't be created with same name in the same service.
- Policy can be created with same resources (resource signature check).
Thanks,
Alok Lal
Re: Review Request 33250: RANGER-278 Re-enable policy validation
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33250/#review80297
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 16, 2015, 12:38 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33250/
> -----------------------------------------------------------
>
> (Updated April 16, 2015, 12:38 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-278
> https://issues.apache.org/jira/browse/RANGER-278
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Re-enabling policy validation that was turned off since policy query logic was WIP
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a9ade43
> security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java f4534a1
> security-admin/src/test/resources/log4j.properties PRE-CREATION
>
> Diff: https://reviews.apache.org/r/33250/diff/
>
>
> Testing
> -------
>
> Did manual testing by excercising REST API
> - Policy can be created with same name if in different service.
> - Policy can't be created with same name in the same service.
> - Policy can't be created with same resources (resource signature check).
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 33250: RANGER-278 Re-enable policy validation
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33250/
-----------------------------------------------------------
(Updated April 15, 2015, 5:38 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Fixed typo in "Testing Done" section.
Bugs: RANGER-278
https://issues.apache.org/jira/browse/RANGER-278
Repository: ranger
Description
-------
Re-enabling policy validation that was turned off since policy query logic was WIP
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java a9ade43
security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java f4534a1
security-admin/src/test/resources/log4j.properties PRE-CREATION
Diff: https://reviews.apache.org/r/33250/diff/
Testing (updated)
-------
Did manual testing by excercising REST API
- Policy can be created with same name if in different service.
- Policy can't be created with same name in the same service.
- Policy can't be created with same resources (resource signature check).
Thanks,
Alok Lal