[GitHub] [superset] john-bodley commented on a change in pull request #17236: fix: revert default series sort-by metric and enforce non-xor with series limit

[GitBox <gi...@apache.org>]

john-bodley commented on a change in pull request #17236:
URL: https://github.com/apache/superset/pull/17236#discussion_r736939490



##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -92,7 +92,7 @@ export const D3_FORMAT_OPTIONS = [
 
 const ROW_LIMIT_OPTIONS = [10, 50, 100, 250, 500, 1000, 5000, 10000, 50000];
 
-const SERIES_LIMITS = [0, 5, 10, 25, 50, 100, 500];
+const SERIES_LIMITS = [5, 10, 25, 50, 100, 500];

Review comment:
       Consistent with https://github.com/apache-superset/superset-ui/pull/1430. Note I'm unsure why things are defined in multiple places.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org