You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/05/11 16:11:21 UTC

[GitHub] [flink-kubernetes-operator] gyfora commented on a diff in pull request #204: [Flink 27329] Add default value of replica of JM pod and not declare it in example yamls

gyfora commented on code in PR #204:
URL: https://github.com/apache/flink-kubernetes-operator/pull/204#discussion_r870507063


##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/crd/spec/FlinkDeploymentSpec.java:
##########
@@ -45,7 +45,7 @@ public class FlinkDeploymentSpec extends AbstractFlinkSpec {
     private String imagePullPolicy;
 
     /** Kubernetes service used by the Flink deployment. */
-    private String serviceAccount;
+    private String serviceAccount = "flink";

Review Comment:
   I suggest to leave it on `null` and throw a validation error if not set.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org