You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/27 05:24:10 UTC
[GitHub] [dubbo-go] justxuewei commented on a diff in pull request #2117: feat: tls support for protocol dubbo/dubbo3
justxuewei commented on code in PR #2117:
URL: https://github.com/apache/dubbo-go/pull/2117#discussion_r1032868912
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
Review Comment:
Nit: Please leave a space for comments, for example `//Deprecated` -> `// Deprecated`
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
serverTlsConfigBuilder getty.TlsConfigBuilder
+ //Deprecated: use TLSConfig instead.
clientTlsConfigBuilder getty.TlsConfigBuilder
)
+//Deprecated: use TLSConfig instead.
func GetServerTlsConfigBuilder() getty.TlsConfigBuilder {
return serverTlsConfigBuilder
}
+//Deprecated: use TLSConfig instead.
Review Comment:
same above
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
serverTlsConfigBuilder getty.TlsConfigBuilder
+ //Deprecated: use TLSConfig instead.
Review Comment:
same above
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
serverTlsConfigBuilder getty.TlsConfigBuilder
+ //Deprecated: use TLSConfig instead.
clientTlsConfigBuilder getty.TlsConfigBuilder
)
+//Deprecated: use TLSConfig instead.
Review Comment:
same above
##########
config/root_config.go:
##########
@@ -65,6 +65,7 @@ type RootConfig struct {
CacheFile string `yaml:"cache_file" json:"cache_file,omitempty" property:"cache_file"`
Custom *CustomConfig `yaml:"custom" json:"custom,omitempty" property:"custom"`
Profiles *ProfilesConfig `yaml:"profiles" json:"profiles,omitempty" property:"profiles"`
+ TLSConfig *TLSConfig `yaml:"tls_config" json:"tls_config,omitempty" property:"tls_config"`
Review Comment:
Please rename the names of yaml and json to "tls-config".
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
serverTlsConfigBuilder getty.TlsConfigBuilder
+ //Deprecated: use TLSConfig instead.
clientTlsConfigBuilder getty.TlsConfigBuilder
)
+//Deprecated: use TLSConfig instead.
func GetServerTlsConfigBuilder() getty.TlsConfigBuilder {
return serverTlsConfigBuilder
}
+//Deprecated: use TLSConfig instead.
func GetClientTlsConfigBuilder() getty.TlsConfigBuilder {
return clientTlsConfigBuilder
}
+// Deprecated: use TLSConfig instead.
Review Comment:
same above
##########
config/ssl_config.go:
##########
@@ -22,22 +22,28 @@ import (
)
var (
+ //Deprecated: use TLSConfig instead.
serverTlsConfigBuilder getty.TlsConfigBuilder
+ //Deprecated: use TLSConfig instead.
clientTlsConfigBuilder getty.TlsConfigBuilder
)
+//Deprecated: use TLSConfig instead.
func GetServerTlsConfigBuilder() getty.TlsConfigBuilder {
return serverTlsConfigBuilder
}
+//Deprecated: use TLSConfig instead.
func GetClientTlsConfigBuilder() getty.TlsConfigBuilder {
return clientTlsConfigBuilder
}
+// Deprecated: use TLSConfig instead.
func SetServerTlsConfigBuilder(configBuilder getty.TlsConfigBuilder) {
serverTlsConfigBuilder = configBuilder
}
+//Deprecated: use TLSConfig instead.
Review Comment:
same above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org