You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@any23.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/04/13 03:12:00 UTC
[jira] [Commented] (ANY23-331) Tool service implementations
declared in wrong module?
[ https://issues.apache.org/jira/browse/ANY23-331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16436735#comment-16436735 ]
ASF GitHub Bot commented on ANY23-331:
--------------------------------------
GitHub user HansBrende opened a pull request:
https://github.com/apache/any23/pull/75
ANY23-331 put META-INF/services tool entries into correct jar file
mvn clean test -> all tests pass
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/HansBrende/any23 ANY23-331
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/any23/pull/75.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #75
----
commit 258c191507cd42ba01fcc59d82219b951c2801da
Author: Hans <fi...@...>
Date: 2018-04-13T03:10:19Z
ANY23-331 put META-INF/services tool entries into correct jar file
----
> Tool service implementations declared in wrong module?
> ------------------------------------------------------
>
> Key: ANY23-331
> URL: https://issues.apache.org/jira/browse/ANY23-331
> Project: Apache Any23
> Issue Type: Bug
> Components: CLI, core
> Affects Versions: 2.1
> Reporter: Hans Brende
> Priority: Major
> Fix For: 2.3
>
>
> It appears that all the {{org.apache.any23.cli.Tool}}-implementing classes are declared in the *core*/src/main/resources/META-INF/services directory instead of the *cli*/src/main/resources/META-INF/services directory (even though all of the referenced Tool implementations occur in the *cli* module, *not* the core module). I'm not sure what effect (if any) this would have on service loading, but this feels wrong. Comments anyone?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)