[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3717: Block changing manager NORMAL state until fate is ready

["ctubbsii (via GitHub)" <gi...@apache.org>]

ctubbsii commented on code in PR #3717:
URL: https://github.com/apache/accumulo/pull/3717#discussion_r1311063441


##########
server/manager/src/main/java/org/apache/accumulo/manager/Manager.java:
##########
@@ -280,38 +280,42 @@ Fate<Manager> fate() {
       /* UNLOAD_ROOT_TABLET */      {O, O, O, X, X, X, X},
       /* STOP */                    {O, O, O, O, O, X, X}};
   //@formatter:on
-  synchronized void setManagerState(ManagerState newState) {
-    if (state.equals(newState)) {
+  synchronized void setManagerState(final ManagerState newState) {
+    if (state == newState) {
       return;
     }
     if (!transitionOK[state.ordinal()][newState.ordinal()]) {
       log.error("Programmer error: manager should not transition from {} to {}", state, newState);

Review Comment:
   Good question. I checked the history, and it looks like this behavior has been the same since the initial commit at the ASF. I could try to investigate the history prior to the software grant agreement, but it would take time and I doubt I'll find any explanation or documentation to explain why.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org