[GitHub] reddycharan commented on a change in pull request #1092: Dont log ledgermetadata which contains password.

[GitBox <gi...@apache.org>]

reddycharan commented on a change in pull request #1092: Dont log ledgermetadata which contains password.
URL: https://github.com/apache/bookkeeper/pull/1092#discussion_r165235043
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerMetadata.java
 ##########
 @@ -336,8 +340,9 @@ LedgerMetadataFormat buildProtoFormat() {
             builder.setCtime(ctime);
         }
 
-        if (hasPassword) {
-            builder.setDigestType(digestType).setPassword(ByteString.copyFrom(password));
 
 Review comment:
   @sijie here, I was not sure why builder.setDigestType is kept in if block. I moved it out of this if block. I guess, it is the right thing to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services