You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "Ismaël Mejía (JIRA)" <ji...@apache.org> on 2019/01/17 16:30:00 UTC

[jira] [Reopened] (BEAM-5933) PCollectionViews$SimplePCollectionView.hashCode allocates memory

     [ https://issues.apache.org/jira/browse/BEAM-5933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ismaël Mejía reopened BEAM-5933:
--------------------------------

Reopening because this is going to be reverted by BEAM-6407

> PCollectionViews$SimplePCollectionView.hashCode allocates memory
> ----------------------------------------------------------------
>
>                 Key: BEAM-5933
>                 URL: https://issues.apache.org/jira/browse/BEAM-5933
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>    Affects Versions: 2.8.0
>            Reporter: Vojtech Janota
>            Assignee: Vojtech Janota
>            Priority: Trivial
>             Fix For: 2.9.0
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> I'm currently profiling memory consumption of our Beam pipeline and have noticed that
>     org.apache.beam.sdk.values.PCollectionViews$SimplePCollectionView.hashCode()
> makes noticeable heap allocations. The implementation is:
>     return Objects.hash(tag);
> That itself translates to:
>     return Arrays.hashCode(values);
> Which performs implicit array creation in order to call:
>     public static int Arrays.hashCode(Object a[]);
> Instead of the helper call, doing simple:
>     tag.hashCode();
> Seems more appropriate.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)