[GitHub] [geode] gesterzhou commented on a change in pull request #5666: GEODE-8652: Allow NioSslEngine.close() to Bypass Locks

[GitBox <gi...@apache.org>]

gesterzhou commented on a change in pull request #5666:
URL: https://github.com/apache/geode/pull/5666#discussion_r513984948



##########
File path: geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##########
@@ -368,17 +365,15 @@ public void doneReadingDirectAck(ByteBuffer unwrappedBuffer) {
     // read-operations
   }
 
-  @Override
-  public synchronized boolean isClosed() {
-    return closed;
-  }
-
   @Override
   public synchronized void close(SocketChannel socketChannel) {

Review comment:
       Will this "synchronized" sync with wrap() method's shareOutputBuffer?
   
   wrap() and close() have to sync with each other, otherwise it will encounter bug Gem-3116. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org