You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2016/11/21 19:35:58 UTC
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Tim Armstrong has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5165
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent of the runtime system
Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
R be/src/runtime/bufferpool/CMakeLists.txt
R be/src/runtime/bufferpool/buffer-allocator.cc
R be/src/runtime/bufferpool/buffer-allocator.h
R be/src/runtime/bufferpool/buffer-pool-counters.h
R be/src/runtime/bufferpool/buffer-pool-test.cc
R be/src/runtime/bufferpool/buffer-pool.cc
R be/src/runtime/bufferpool/buffer-pool.h
R be/src/runtime/bufferpool/reservation-tracker-counters.h
R be/src/runtime/bufferpool/reservation-tracker-test.cc
R be/src/runtime/bufferpool/reservation-tracker.cc
R be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/mem-tracker.cc
15 files changed, 14 insertions(+), 16 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/5165/1
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5165/1/be/src/runtime/bufferpool/buffer-allocator.h
File be/src/runtime/bufferpool/buffer-allocator.h:
Line 18: #ifndef IMPALA_BUFFER_ALLOCATOR_H
> let's also add a _RUNTIME to the include guards.
Done
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5165
to look at the new patch set (#2).
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent of the runtime system
Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
R be/src/runtime/bufferpool/CMakeLists.txt
R be/src/runtime/bufferpool/buffer-allocator.cc
R be/src/runtime/bufferpool/buffer-allocator.h
R be/src/runtime/bufferpool/buffer-pool-counters.h
R be/src/runtime/bufferpool/buffer-pool-test.cc
R be/src/runtime/bufferpool/buffer-pool.cc
R be/src/runtime/bufferpool/buffer-pool.h
R be/src/runtime/bufferpool/reservation-tracker-counters.h
R be/src/runtime/bufferpool/reservation-tracker-test.cc
R be/src/runtime/bufferpool/reservation-tracker.cc
R be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/mem-tracker.cc
15 files changed, 24 insertions(+), 26 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/5165/2
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent of the runtime system
Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Reviewed-on: http://gerrit.cloudera.org:8080/5165
Reviewed-by: Tim Armstrong <ta...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
R be/src/runtime/bufferpool/CMakeLists.txt
R be/src/runtime/bufferpool/buffer-allocator.cc
R be/src/runtime/bufferpool/buffer-allocator.h
R be/src/runtime/bufferpool/buffer-pool-counters.h
R be/src/runtime/bufferpool/buffer-pool-test.cc
R be/src/runtime/bufferpool/buffer-pool.cc
R be/src/runtime/bufferpool/buffer-pool.h
R be/src/runtime/bufferpool/reservation-tracker-counters.h
R be/src/runtime/bufferpool/reservation-tracker-test.cc
R be/src/runtime/bufferpool/reservation-tracker.cc
R be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/mem-tracker.cc
15 files changed, 25 insertions(+), 27 deletions(-)
Approvals:
Impala Public Jenkins: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 4
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 3:
Build started: http://ec2-35-161-220-160.us-west-2.compute.amazonaws.com:8080/job/gerrit-verify-dryrun/38/
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Hello Marcel Kornacker, Internal Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/5165
to look at the new patch set (#3).
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
IMPALA-3200: move bufferpool under runtime
It is arguably a subcomponent of the runtime system
Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
---
M .clang-tidy
M be/CMakeLists.txt
M be/src/runtime/CMakeLists.txt
R be/src/runtime/bufferpool/CMakeLists.txt
R be/src/runtime/bufferpool/buffer-allocator.cc
R be/src/runtime/bufferpool/buffer-allocator.h
R be/src/runtime/bufferpool/buffer-pool-counters.h
R be/src/runtime/bufferpool/buffer-pool-test.cc
R be/src/runtime/bufferpool/buffer-pool.cc
R be/src/runtime/bufferpool/buffer-pool.h
R be/src/runtime/bufferpool/reservation-tracker-counters.h
R be/src/runtime/bufferpool/reservation-tracker-test.cc
R be/src/runtime/bufferpool/reservation-tracker.cc
R be/src/runtime/bufferpool/reservation-tracker.h
M be/src/runtime/mem-tracker.cc
15 files changed, 25 insertions(+), 27 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/65/5165/3
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Marcel Kornacker (Code Review)" <ge...@cloudera.org>.
Marcel Kornacker has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5165/1/be/src/runtime/bufferpool/buffer-allocator.h
File be/src/runtime/bufferpool/buffer-allocator.h:
Line 18: #ifndef IMPALA_BUFFER_ALLOCATOR_H
let's also add a _RUNTIME to the include guards.
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 2: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Internal Jenkins (Code Review)" <ge...@cloudera.org>.
Internal Jenkins has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 2: Verified-1
Build failed: http://sandbox.jenkins.cloudera.com/job/impala-external-gerrit-verify-merge-ASF/512/
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-3200: move bufferpool under runtime
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-3200: move bufferpool under runtime
......................................................................
Patch Set 3: Code-Review+2
The Cmake script didn't handle be tests living in a subdirectory - fixed it.
--
To view, visit http://gerrit.cloudera.org:8080/5165
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3507066fb5cb955f0872d31a4619bd8bb7d647cd
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Internal Jenkins
Gerrit-Reviewer: Marcel Kornacker <ma...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No