You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2013/12/12 22:49:38 UTC
Review Request 16225: Added more overloaded functions of min/max in Option.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16225/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f93bc15
3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp be56d1f
Diff: https://reviews.apache.org/r/16225/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 16225: Added more overloaded functions of min/max in
Option.
Posted by Jie Yu <yu...@gmail.com>.
> On Dec. 12, 2013, 9:58 p.m., Ben Mahler wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp, line 115
> > <https://reviews.apache.org/r/16225/diff/1/?file=397015#file397015line115>
> >
> > Wouldn't the implicit Option constructor have worked instead of needing overloads?
Probably because 'min' is a template function and it's not instantiated yet.
- Jie
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16225/#review30287
-----------------------------------------------------------
On Dec. 12, 2013, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16225/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 9:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f93bc15
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp be56d1f
>
> Diff: https://reviews.apache.org/r/16225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 16225: Added more overloaded functions of min/max in
Option.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16225/#review30287
-----------------------------------------------------------
3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp
<https://reviews.apache.org/r/16225/#comment57974>
Wouldn't the implicit Option constructor have worked instead of needing overloads?
- Ben Mahler
On Dec. 12, 2013, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16225/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 9:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f93bc15
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp be56d1f
>
> Diff: https://reviews.apache.org/r/16225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 16225: Added more overloaded functions of min/max in
Option.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16225/#review30284
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 12, 2013, 9:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16225/
> -----------------------------------------------------------
>
> (Updated Dec. 12, 2013, 9:49 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Ben Mahler, and Jiang Yan Xu.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/3rdparty/stout/include/stout/option.hpp f93bc15
> 3rdparty/libprocess/3rdparty/stout/tests/option_tests.cpp be56d1f
>
> Diff: https://reviews.apache.org/r/16225/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>