You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/07/21 16:19:06 UTC
[GitHub] [superset] john-bodley commented on a change in pull request #15757: chore: Enforce Mypy for non-tests
john-bodley commented on a change in pull request #15757:
URL: https://github.com/apache/superset/pull/15757#discussion_r674140292
##########
File path: RELEASING/send_email.py
##########
@@ -61,7 +63,7 @@ def send_email(
server.sendmail(sender_email, receiver_email, message)
-def render_template(template_file: str, **kwargs) -> str:
+def render_template(template_file: str, **kwargs: Any) -> str:
Review comment:
`kwargs` are mostly represented as `Any` elsewhere in the code base. I think a follow up PR should make a sweep of the entire repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org