You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2022/10/25 09:33:58 UTC
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Wang Xixu has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19166
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
[IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
It continues the work of https://gerrit.cloudera.org/c/10983/
See document:
https://kudu.apache.org/2018/09/26/index-skip-scan-optimization-in-kudu.html
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
9 files changed, 981 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/1
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 1
Gerrit-Owner: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#3).
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
[IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
It continues the work of https://gerrit.cloudera.org/c/10983/
See document:
https://kudu.apache.org/2018/09/26/index-skip-scan-optimization-in-kudu.html
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
M src/kudu/tserver/tablet_server-test.cc
12 files changed, 1,039 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/3
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 3
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19166 )
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h
File src/kudu/cfile/cfile_reader.h:
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h@350
PS1, Line 350: Status SeekAtOrAfter(const EncodedKey& key,
> warning: function 'kudu::cfile::CFileIterator::SeekAtOrAfter' has a definit
Done
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/cfile/cfile_reader.h@351
PS1, Line 351: bool* exact_match, bool cache_seeked_value = false);
> warning: invalid case style for parameter 'SeekAtOrAfter' [readability-iden
Done
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc
File src/kudu/tablet/index_skipscan-test.cc:
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@186
PS1, Line 186: return num_matching;
> warning: method 'CreateSchema' can be made static [readability-convert-memb
Done
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@259
PS1, Line 259:
> warning: floating point literal has suffix 'f', which is not uppercase [rea
Done
http://gerrit.cloudera.org:8080/#/c/19166/1/src/kudu/tablet/index_skipscan-test.cc@659
PS1, Line 659: ASSERT_EQ(num_matching, results.size());
> warning: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TE
Done
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 08:50:59 +0000
Gerrit-HasComments: Yes
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#8).
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
[IndexSkip] Efficiently support predicates on non-prefix key
This patch implements index skip scan approach in the case
when there exists an equality predicate on any of the non-first
primary key columns.
It continues the work: https://gerrit.cloudera.org/c/10983/
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
11 files changed, 1,065 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/8
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 8
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#7).
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
[IndexSkip] Efficiently support predicates on non-prefix key
This patch implements index skip scan approach in the case
when there exists an equality predicate on any of the non-first
primary key columns.
It continues the work: https://gerrit.cloudera.org/c/10983/
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/deltafile.cc
A src/kudu/tablet/index_skipscan-test.cc
12 files changed, 1,066 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/7
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#9).
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
[IndexSkip] Efficiently support predicates on non-prefix key
This patch implements index skip scan approach in the case
when there exists an equality predicate on any of the non-first
primary key columns.
It continues the work: https://gerrit.cloudera.org/c/10983/
Additionly, the patch supports multiple predicates for
index skip.
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
11 files changed, 1,117 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/9
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 9
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19166 )
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
Patch Set 4:
(1 comment)
> Patch Set 2:
>
> (1 comment)
http://gerrit.cloudera.org:8080/#/c/19166/2/src/kudu/common/encoded_key.h
File src/kudu/common/encoded_key.h:
http://gerrit.cloudera.org:8080/#/c/19166/2/src/kudu/common/encoded_key.h@19
PS2, Line 19: #include <cstddef>
> warning: inclusion of deprecated C++ header 'stdint.h'; consider using 'cst
Done
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Wed, 26 Oct 2022 09:40:47 +0000
Gerrit-HasComments: Yes
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#6).
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
[IndexSkip] Efficiently support predicates on non-prefix key
This patch implements index skip scan approach in the case
when there exists an equality predicate on any of the non-first
primary key columns.
It continues the work: https://gerrit.cloudera.org/c/10983/
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/deltafile.cc
A src/kudu/tablet/index_skipscan-test.cc
12 files changed, 1,065 insertions(+), 11 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/6
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 6
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19166 )
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
Patch Set 10:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/19166/9/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:
http://gerrit.cloudera.org:8080/#/c/19166/9/src/kudu/tablet/cfile_set.cc@464
PS9, Line 464: if (non_prefix_key_exists) {
> warning: do not use 'else' after 'continue' [readability-else-after-return]
Done
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Thu, 12 Jan 2023 09:27:30 +0000
Gerrit-HasComments: Yes
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#10).
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
[IndexSkip] Efficiently support predicates on non-prefix key
This patch implements index skip scan approach in the case
when there exists an equality predicate on any of the non-first
primary key columns.
It continues the work: https://gerrit.cloudera.org/c/10983/
Additionly, the patch supports multiple predicates for
index skip.
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
11 files changed, 1,173 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/10
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 10
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#5).
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
[IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
It continues the work of https://gerrit.cloudera.org/c/10983/
See document:
https://kudu.apache.org/2018/09/26/index-skip-scan-optimization-in-kudu.html
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
M src/kudu/tablet/deltafile.cc
A src/kudu/tablet/index_skipscan-test.cc
M src/kudu/tablet/tablet-test-util.h
M src/kudu/tserver/tablet_server-test.cc
14 files changed, 1,069 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/5
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 5
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#2).
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
[IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
It continues the work of https://gerrit.cloudera.org/c/10983/
See document:
https://kudu.apache.org/2018/09/26/index-skip-scan-optimization-in-kudu.html
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
9 files changed, 1,035 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/2
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 2
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
[kudu-CR] [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19166
to look at the new patch set (#4).
Change subject: [IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
......................................................................
[IndexSkip][Optimization] Efficiently support predicates on non-prefix key components
This patch implements index skip scan approach in the case when there
exists an equality predicate on any of the non-first
primary key columns.
It continues the work of https://gerrit.cloudera.org/c/10983/
See document:
https://kudu.apache.org/2018/09/26/index-skip-scan-optimization-in-kudu.html
Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
---
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/common/encoded_key.cc
M src/kudu/common/encoded_key.h
M src/kudu/common/partial_row.h
M src/kudu/fs/block_manager-stress-test.cc
M src/kudu/fs/file_block_manager.cc
M src/kudu/tablet/CMakeLists.txt
M src/kudu/tablet/cfile_set.cc
M src/kudu/tablet/cfile_set.h
A src/kudu/tablet/index_skipscan-test.cc
M src/kudu/tserver/tablet_server-test.cc
12 files changed, 1,038 insertions(+), 8 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/66/19166/4
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 4
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
[kudu-CR] [IndexSkip] Efficiently support predicates on non-prefix key
Posted by "Wang Xixu (Code Review)" <ge...@cloudera.org>.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/19166 )
Change subject: [IndexSkip] Efficiently support predicates on non-prefix key
......................................................................
Patch Set 7:
(3 comments)
http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.h
File src/kudu/tablet/cfile_set.h:
http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.h@318
PS6, Line 318: int64_t index_skip_num_seeks_cutoff_ = 0;
> warning: invalid case style for private member '_index_skip_first_seek_' [r
Done
http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc
File src/kudu/tablet/cfile_set.cc:
http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc@19
PS6, Line 19: #include <algorithm>
> warning: inclusion of deprecated C++ header 'math.h'; consider using 'cmath
Done
http://gerrit.cloudera.org:8080/#/c/19166/6/src/kudu/tablet/cfile_set.cc@481
PS6, Line 481: }
> warning: 1st function call argument is an uninitialized value [clang-analyz
Done
--
To view, visit http://gerrit.cloudera.org:8080/19166
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie294dc8455e558f3d0b093eee69ec3830f5edbce
Gerrit-Change-Number: 19166
Gerrit-PatchSet: 7
Gerrit-Owner: Wang Xixu <14...@qq.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Thu, 22 Dec 2022 08:29:43 +0000
Gerrit-HasComments: Yes