You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by big-loser <gi...@git.apache.org> on 2017/10/07 04:01:31 UTC

[GitHub] zeppelin pull request #2611: Issues found through editing Note Permission

GitHub user big-loser opened a pull request:

    https://github.com/apache/zeppelin/pull/2611

    Issues found through editing Note Permission

    I was trying to use LDAP authorization manner to login and looks like the Reader could edit the entire Note Permission which supposed to be read only.
    
    For example I am UserA, I am the owner and writer of the Notebook, and set UserB as the reader. However, once UserB logged in, s/he could remove the owner (UserA) and becomes as the Owner of the Notebook.
    
    Would you please help resolve?
    
    Thank you!

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/zeppelin branch-0.7

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2611.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2611
    
----
commit 350cf9c294114cd40ceef00c570d8f53caeea922
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-01-13T05:32:02Z

    [ZEPPELIN-1963] set cron job executor to current user by default
    
    ### What is this PR for?
    currently when executing cron job, backend doesn't know who initiated cron job (with subsequent save) unless user puts his name. This PR adds user name by default by keeping compatibility with current workflow.
    
    ### What type of PR is it?
    Improvement
    
    ### Todos
    * [x] - add user on front
    
    ### What is the Jira issue?
    [ZEPPELIN-1963](https://issues.apache.org/jira/browse/ZEPPELIN-1963)
    
    ### How should this be tested?
    go and set cron job
    
    ### Screenshots (if appropriate)
    ![cron_user](https://cloud.githubusercontent.com/assets/1642088/21919566/25330daa-d910-11e6-9373-aa3c44064f39.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Khalid Huseynov <kh...@gmail.com>
    
    Closes #1898 from khalidhuseynov/cron-user and squashes the following commits:
    
    30dc440 [Khalid Huseynov] add logged cron executing user
    
    (cherry picked from commit 8daf32563960b16db739e30c8dcd91d60f854917)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 2665d709a9f7888a644e3eed4df6ae115044268f
Author: Jeff Zhang <zj...@apache.org>
Date:   2016-12-28T11:08:22Z

    ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo
    
    ### What is this PR for?
    Refactor the livy interpreter to use multiple `InterpreterResult` for displaying appInfo.
    
    ### What type of PR is it?
    [Refactoring]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1852
    
    ### How should this be tested?
    Add integration test and also test it manually
    
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/164491/21446774/691b84fe-c905-11e6-91a1-9dcc57c75f3c.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #1796 from zjffdu/ZEPPELIN-1852 and squashes the following commits:
    
    724f22e [Jeff Zhang] update doc
    e1c2eb9 [Jeff Zhang] ZEPPELIN-1852. Use multiple InterpreterResult for displaying appInfo
    
    (cherry picked from commit 69b866adca5ecac00b26dfd3573013eaae133102)
    Signed-off-by: Felix Cheung <fe...@apache.org>

commit 759f3fa6edde88312a55384cc8bfcf32364f3d9f
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-17T10:42:43Z

    [DOCS] Update interpter installation guide
    
    ### What is this PR for?
    * Update Scio interpreter's artifact name from `scio` to `scio_2.11`, which will be used for installing scio interpreter from netinst binary package.
    * Fix typos
    
    ### What type of PR is it?
    Documentation | Hotfix
    
    ### What is the Jira issue?
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Mina Lee <mi...@apache.org>
    
    Closes #1906 from minahlee/docs/interpreterInstall and squashes the following commits:
    
    56eeab3 [Mina Lee] Update interpter installation guide
    
    (cherry picked from commit 26808e3a07d43b2533785bd08ed9d47948f3e778)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 2256f31e81de13ebf43475c897eac548f638083b
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-01-18T07:10:07Z

    ZEPPELIN-1977. spark 2.1 uses a more recent commons-lang3
    
    ### What is this PR for?
    The issue is that spark 2.1 use `commons-lang3` 3.5 while `zeppelin-interpreter` use 3.4. We can not just upgrade `commons-lang3` to 3.5, as it just make spark 2.1 work, but would fail other versions of spark. This PR remove `commons-lang3` from zeppelin-interpreter. We should keep zeppelin-interpreter's dependencies as minimum as possible. We can remove other dependencies (like `commons-lang`) from `zeppelin-interpreter` in a followup PR.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-1977
    
    ### How should this be tested?
    Tested manually
    ![2017-01-18_1448](https://cloud.githubusercontent.com/assets/164491/22054522/f125e836-dd90-11e6-9acf-d73541046d95.png)
     on 3 versions of spark (2.1, 2.0.2, 1.6.2)
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #1910 from zjffdu/ZEPPELIN-1977 and squashes the following commits:
    
    8bac97f [Jeff Zhang] ZEPPELIN-1977. spark 2.1 uses a more recent commons-lang3
    
    (cherry picked from commit 88a905caf2043d12a85462940c451b424d218dba)
    Signed-off-by: Lee moon soo <mo...@apache.org>

commit b311ee719bf99da25f7a5226b6663309d4ddb274
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-16T18:13:45Z

    [ZEPPELIN-1974] Remove extension from webpack config for visualization bundle
    
    ### What is this PR for?
    webpack.config.js for creating visualization bundle has unnecessary extension configuration, which makes unable to import some libraries.
    
    This PR removes the unnecessary configuration and propagate 'npm install' error message to front-end.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - exclude 'extensions' from webpack.config.js for visualization bundle
    * [x] - propagate 'npm install' error to front-end
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1974
    
    ### Screenshots (if appropriate)
    
    Before propagate error message to front-end
    ![image](https://cloud.githubusercontent.com/assets/1540981/21994155/2095e554-dbd3-11e6-8923-8deafecd350b.png)
    
    After propagate error message to front-end
    ![image](https://cloud.githubusercontent.com/assets/1540981/21994317/f8ffdcec-dbd3-11e6-8bec-156aa2d5bdf7.png)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #1905 from Leemoonsoo/npm_install_error and squashes the following commits:
    
    b665588 [Lee moon soo] Propagate npm install error to front-end
    7635c55 [Lee moon soo] Remove extension from webpack config for visualization bundle
    
    (cherry picked from commit 28a8be46835a0ef1808e6336f3e020ad06a5db46)
    Signed-off-by: Lee moon soo <mo...@apache.org>

commit 392a0bad2fa0947b8b5f311599c6b0f63cc04a95
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-19T07:28:30Z

    [BUILD] Remove docker build from release script
    
    ### What is this PR for?
    Removing docker build and push from release script.
    Docker managed by community will be supported sooner or later through https://hub.docker.com/r/apache/ or official docker hub repository, and either way doesn't need push from release script.
    
    ### What type of PR is it?
    Build
    
    ### What is the Jira issue?
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Mina Lee <mi...@apache.org>
    
    Closes #1926 from minahlee/remove_docker_build and squashes the following commits:
    
    6ea789e [Mina Lee] Publish beam interpreter in maven central repo
    3a9b64e [Mina Lee] Remove docker build
    
    (cherry picked from commit 53f8fa167b7ef95495588940ae87cabd8a377321)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit bcbe0855175f55eddd10b918303806eb5e5db091
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-21T08:18:41Z

    Preparing Apache Zeppelin release 0.7.0

commit e713c32e99cdd66a6a5823a5d0f156506c5069fd
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-21T08:23:22Z

    Preparing development version 0.7.1-SNAPSHOT

commit ca62d386a5c4f14c3bc69b4ddaf124efb6498a78
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-01-22T04:52:55Z

    ZEPPELIN-1985 Remove user from pig tutorial note
    
    ### What is this PR for?
    Should remove the user from pig tutorial note, otherwise it can not be seen in anonymous mode.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1985
    
    ### How should this be tested?
    Tested it in anonymous mode
    
    ### Screenshots (if appropriate)
    
    ![image](https://cloud.githubusercontent.com/assets/164491/22135013/5f34ad78-df06-11e6-9043-fffce363bb9e.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #1915 from zjffdu/ZEPPELIN-1985 and squashes the following commits:
    
    4432f89 [Jeff Zhang] add downloading bank.csv
    c92b8f3 [Jeff Zhang] ZEPPELIN-1985. Remove user from pig tutorial note
    
    (cherry picked from commit 3c5d1283b58fbb54057526bd85fd0b95c6a4da90)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit a45ef6bdc6a36d00385f99442a74070f9fd444b1
Author: Alex Goodman <ag...@users.noreply.github.com>
Date:   2017-01-19T00:29:20Z

    [HOTFIX][ZEPPELIN-1980] - Test and update CI for matplotlib 2.0.0
    
    ### What is this PR for?
    Matplotlib 2.0.0 was just released. It has introduced some major changes including some to the `rcParams` which makes it incompatible with Zeppelin's built-in plotting backend. This PR updates the backend config for 2.0.0 as well as the CI tests.
    
    ### What type of PR is it?
    Hot Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-1980](https://issues.apache.org/jira/browse/ZEPPELIN-1980)
    
    ### How should this be tested?
    Run the matplotlib tutorial notebook with matplotlib 2.0.0 installed.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    If possible, this should be included as a hotfix for 0.7.0.
    
    Author: Alex Goodman <ag...@users.noreply.github.com>
    
    Closes #1912 from agoodm/ZEPPELIN-1980 and squashes the following commits:
    
    202548c [Alex Goodman] Use figure.dpi instead of savefig.dpi
    2678359 [Alex Goodman] Make CI install latest matplotlib
    
    (cherry picked from commit 7941d37518a9393435680833c0828b13c77dd863)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit d0ddf8fdff75b4229543f7ebfd5eb001f685382d
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-22T06:05:36Z

    Preparing Apache Zeppelin release 0.7.0

commit 9ed215e2b60e7b4ce6da158191d4b7c640753b57
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-22T06:07:37Z

    Preparing development version 0.7.1-SNAPSHOT

commit 7066aff9a21f2fab4f4857494926b9d60488cb58
Author: astroshim <hs...@zepl.com>
Date:   2017-01-21T09:06:52Z

    [ZEPPELIN-1994] bugfix of streaming output.
    
    ### What is this PR for?
    If you run the following code, then streaming output doesn't work properly from the second run.
    ```
    %spark.pyspark
    import time
    print("1")
    time.sleep(2)
    print("2")
    time.sleep(2)
    print("3")
    time.sleep(2)
    print("4")
    ```
    This problem comes from the order of `paragraph update` event timing and `paragraph update-append` event timing is incorrect.
    and This PR will fix also https://github.com/apache/zeppelin/pull/1833 too.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1994
    
    ### How should this be tested?
    - run several times pyspark interpreter with above code.
    
    ### Screenshots (if appropriate)
    - before
    ![2017-01-21 00_55_25](https://cloud.githubusercontent.com/assets/3348133/22173437/bfa48e64-df77-11e6-9625-ab44dedee395.gif)
    
    - after
    ![2017-01-21 00_59_12](https://cloud.githubusercontent.com/assets/3348133/22173438/c21820ac-df77-11e6-87dc-07970fca13ca.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions?no
    * Does this needs documentation?no
    
    Author: astroshim <hs...@zepl.com>
    
    Closes #1927 from astroshim/ZEPPELIN-1994 and squashes the following commits:
    
    c7baa59 [astroshim] fix streaming output problem
    
    (cherry picked from commit 1a1fbc423bc2631000e0ecad2e792efc377a4fd5)
    Signed-off-by: ahyoungryu <ah...@apache.org>

commit d5c8d175fb16a156132ec363fdbaa6b09223c288
Author: astroshim <hs...@zepl.com>
Date:   2017-01-21T00:18:40Z

    [ZEPPELIN-1991] Can't get the PARAGRAPH_APPEND_OUTPUT from the Interpreter.
    
    ### What is this PR for?
    This PR fixes the problem of streaming events(PARAGRAPH_APPEND_OUTPUT).
    It's because of the queue was not thread safe.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1991
    
    ### How should this be tested?
    1. make a spark paragraph
    
    2. run following code on spark paragraph.
    ```
    %spark
    (1 to 5).foreach{ i=>
        Thread.sleep(1000)
        println("Hello " + i)
    }
    
    ```
    3. make a python paragraph
    
    4. run following code on python paragraph.
    ```
    %python.python
    
    print("hi1")
    ```
    
    5. retry run step 2, and check if streaming working.
    
    ### Screenshots (if appropriate)
    - before
    ![2017-01-20 13_36_02](https://cloud.githubusercontent.com/assets/3348133/22166640/edb9f610-df16-11e6-926c-c781f618e6cf.gif)
    
    - after
    ![2017-01-20 13_52_53](https://cloud.githubusercontent.com/assets/3348133/22166840/efd855e4-df17-11e6-816c-17e069cd6a04.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: astroshim <hs...@zepl.com>
    
    Closes #1922 from astroshim/ZEPPELIN-1991 and squashes the following commits:
    
    e993585 [astroshim] make scheduler not static
    66d3d2f [astroshim] fix to thread safe
    
    (cherry picked from commit 4ef4e186946f7a0df7da6cd3d0718e60a4975d62)
    Signed-off-by: ahyoungryu <ah...@apache.org>

commit d90615e4fbbd366005373f155900d0be9ffa1910
Author: CloverHearts <cl...@gmail.com>
Date:   2017-01-21T13:46:22Z

    [ZEPPELIN-969] order by note name in job menu
    
    ### What is this PR for?
    we can sort by note name in job menu.
    Sorting supports ascending and descending order.
    Sort by note name.
    
    ### What type of PR is it?
    Feature
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-969
    
    ### How should this be tested?
    click to name order button.
    
    ### Screenshots (if appropriate)
    ![nameorder](https://cloud.githubusercontent.com/assets/10525473/20826460/66a7e7a6-b8ae-11e6-8e03-e2b00698e069.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: CloverHearts <cl...@gmail.com>
    Author: cloverhearts <cl...@gmail.com>
    
    Closes #1721 from cloverhearts/jobm/nameOrder and squashes the following commits:
    
    6df5688 [cloverhearts] change tooltip msg
    4230a2a [cloverhearts] Merge branch 'master' into jobm/nameOrder
    d5bca61 [cloverhearts] Merge branch 'master' into jobm/nameOrder
    11ffe68 [cloverhearts] Merge branch 'master' into jobm/nameOrder
    57347c2 [cloverhearts] change filter icon
    ead26f4 [CloverHearts] Merge branch 'master' into jobm/nameOrder
    5383a2e [CloverHearts] Merge branch 'master' into jobm/nameOrder
    88d4708 [CloverHearts] fix code style
    ff44245 [CloverHearts] Merge branch 'master' into jobm/nameOrder
    6142b8e [CloverHearts] Revert "change sortBy to orderby"
    3b698fb [CloverHearts] change sortBy to orderby
    e8a6588 [CloverHearts] Merge branch 'master' into jobm/nameOrder
    da09527 [CloverHearts] Rename notebook to note.
    2d9fc27 [CloverHearts] order by note name in job menu
    
    (cherry picked from commit 062b90a5d0c47345963bea00a4d69316276327b1)
    Signed-off-by: ahyoungryu <ah...@apache.org>

commit 5381adc6cbbb7a12cf682f03e404e4193239ff8a
Author: Prabhjyot Singh <pr...@gmail.com>
Date:   2017-01-20T16:21:36Z

    Remove multple artifactId - hadoop-common
    
    ### What is this PR for?
    Remove multple artifactId - hadoop-common in JDBC
    
    ### What type of PR is it?
    [Refactor | Minor]
    
    ### Todos
    * [ ] - N/A
    
    ### What is the Jira issue?
    * [ZEPPELIN-1989](https://issues.apache.org/jira/browse/ZEPPELIN-1989)
    
    ### How should this be tested?
    Just a small refactor.
    CI should be green.
    
    ### Screenshots (if appropriate)
    N/A
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A
    
    Author: Prabhjyot Singh <pr...@gmail.com>
    
    Closes #1918 from prabhjyotsingh/ZEPPELIN-1989 and squashes the following commits:
    
    dcdbf74 [Prabhjyot Singh] remove multple artifactId - hadoop-common
    
    (cherry picked from commit 584b1d94e22adc7b915c77d8ca71b0b2ed0ea7c2)
    Signed-off-by: Prabhjyot Singh <pr...@gmail.com>

commit 2005dfe6c4cab70b8cedf62c6fc2cb42c5b6e49f
Author: Khalid Huseynov <kh...@gmail.com>
Date:   2017-01-19T05:28:56Z

    [ZEPPELIN-1979] fix 'File size limit Exceeded' when importing notes
    
    ### What is this PR for?
    This is to fix the problem with import of note because of size limitations. Actually it seemed to be working in anonymous mode, and I noticed the problem only when authentication is enabled.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    * [x] - list conf on successful login
    
    ### What is the Jira issue?
    [ZEPPELIN-1979](https://issues.apache.org/jira/browse/ZEPPELIN-1979)
    
    ### How should this be tested?
    1. set note msg size value in `conf/zeppelin-env.sh` e.g.
    ```
    export ZEPPELIN_WEBSOCKET_MAX_TEXT_MESSAGE_SIZE="4096000"
    ```
    2.  login to Zeppelin
    3. try to import note unde 4MB
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Khalid Huseynov <kh...@gmail.com>
    
    Closes #1913 from khalidhuseynov/fix/note-message-size and squashes the following commits:
    
    3cf02fe [Khalid Huseynov] list conf on login
    
    (cherry picked from commit de659a5ed882ffca37626b5f6d5e5f0f014a2e01)
    Signed-off-by: Lee moon soo <mo...@apache.org>

commit df6b8562723957b658e6afdd143b4a60601aeadc
Author: Kavin <ka...@imaginea.com>
Date:   2016-12-28T07:39:19Z

    [ZEPPELIN-1843] Error on invoking the REST API to run paragraph synchronously
    
    ### What is this PR for?
    This fixes the validation check of paragraph's note id to match with the Note instance id.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    NA
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1843
    
    ### How should this be tested?
    The run para synchronous REST API should be successful.
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Kavin <ka...@imaginea.com>
    
    Closes #1808 from kavinkumarks/zeppelin-1843-run-para-sync-api-error and squashes the following commits:
    
    b5f2927 [Kavin] Throw IAE only when the note id of the instance and paragraph's note id doesn't match.
    
    (cherry picked from commit e49fb47de88897427b915ffec3f8936deebb5dc6)
    Signed-off-by: Lee moon soo <mo...@apache.org>

commit bf09c1457b2356602e59bee0999085a36dcc8e54
Author: Igor Drozdov <ig...@epam.com>
Date:   2016-12-19T10:00:39Z

    [ZEPPELIN-1837] Fix possible reason of DepInterpreterTest failure
    
    ### What is this PR for?
    Fix possible reason of DepInterpreterTest failure
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    [ZEPPELIN-1837](https://issues.apache.org/jira/browse/ZEPPELIN-1837)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    DepInterpreterTest will use random temporary folder for repo
    
    `DefaultRepositorySystem.resolveDependencies` throws NPE at line 352
    if `ArtifactResolutionException` is thrown during `collectDependencies`.
    Artifact is found but it is impossible to download it (for example folder
    can't be created)
    
    I think the reason is that several tests use "local-repo" folder for repository.
    While one test tries to download artifact, another deletes repository
    (or some another distructive thing)
    
    Author: Igor Drozdov <ig...@epam.com>
    
    Closes #1782 from DrIgor/ZEPPELIN-1837 and squashes the following commits:
    
    a2af135 [Igor Drozdov] Fix possible reason of DepInterpreterTest failure
    
    (cherry picked from commit 2cc10d0ba78362b3c4d351a6e3044b73dc5404eb)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 792687182c9d94d256b79080bf11aef078d67a82
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-20T21:39:26Z

    [ZEPPELIN-1986] Fix flaky test: Increase WelcomePageSuite timeout
    
    ### What is this PR for?
    Try fix problem described in https://issues.apache.org/jira/browse/ZEPPELIN-1986.
    Almost all recent build has this failure on CI build.
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Increase timeout
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1986
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #1919 from Leemoonsoo/ZEPPELIN-1986-fix and squashes the following commits:
    
    2a7c1ba [Lee moon soo] Increase timeout from AbstractFunctionalSuite, too
    21e6840 [Lee moon soo] Increase WelcomePageSuite timeout
    
    (cherry picked from commit f604dffa380e4a6474284ec2ca857d7d89e33ed0)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 12763f9ca68ad803974df809d0fa7b8e47b54a24
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-20T21:26:25Z

    [ZEPPELIN-1455] Fix flaky test: AbstractAngularElemTest
    
    ### What is this PR for?
    This PR fix flaky test [ZEPPELIN-1455](https://issues.apache.org/jira/browse/ZEPPELIN-1455).
    
    According to http://doc.scalatest.org/1.8/org/scalatest/concurrent/Eventually.html, default timeout of eventually is 150millisecond. Set enough timeout for the test.
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - increase timeout
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1455
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #1920 from Leemoonsoo/ZEPPELIN-1455 and squashes the following commits:
    
    13a993d [Lee moon soo] Increase tolerance of eventually
    
    (cherry picked from commit 99c21c4edab8f588e57b95c27e957b8bb882560f)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit aa3d319c8e4f0f1ac120c6996b6803566b63d227
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-20T23:01:32Z

    [ZEPPELIN-1857] Fix flaky test: NotebookTest.testAbortParagraphStatusOnInterpreterRestart()
    
    ### What is this PR for?
    This PR fixes flaky test NotebookTest.testAbortParagraphStatusOnInterpreterRestart()
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - re implement NotebookTest.testAbortParagraphStatusOnInterpreterRestart()
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1857
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #1923 from Leemoonsoo/ZEPPELIN-1857 and squashes the following commits:
    
    5d60e5b [Lee moon soo] Fix NotebookTest.testAbortParagraphStatusOnInterpreterRestart()
    
    (cherry picked from commit 236bf3ad6f8300e61321f64bccc8a7540e02e59f)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 4eb29bd7e01c8a75b915f2f73c9b580d223ca9f7
Author: Lee moon soo <mo...@apache.org>
Date:   2017-01-21T00:41:22Z

    [ZEPPELIN-1749] Fix Flaky test: in Websequence markdown plugin
    
    ### What is this PR for?
    Fix flaky test n Websequence markdown plugin.
    Test is failing when request to websequence is failed (network issue, etc).
    
    This PR increases timeout and remove assert from unittest. (log error and pass)
    
    ### What type of PR is it?
    Hot Fix
    
    ### Todos
    * [x] - Increase timeout
    * [x] - Log error and pass instead of assert in unittest.
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1749
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: Lee moon soo <mo...@apache.org>
    
    Closes #1925 from Leemoonsoo/ZEPPELIN-1749 and squashes the following commits:
    
    93b3a15 [Lee moon soo] Increase websequence request timeout, and log unittest instead of assert
    
    (cherry picked from commit 638e4c2f51177ab984dba611e33c7c39b80319ec)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit c0bae0e134f8898cb9fceb793add51b50e506fc5
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-23T05:08:38Z

    [ZEPPELIN-2000] Run paragraph on enter when select dynamic form value changed
    
    ### What is this PR for?
    Run paragraph on enter when select dynamic form value changed to make paragraph runnable in report mode.
    
    ### What type of PR is it?
    Bug Fix | Hot Fix
    
    ### What is the Jira issue?
    [ZEPPELIN-2000](https://issues.apache.org/jira/browse/ZEPPELIN-2000)
    
    ### How should this be tested?
    1. Go to `Zeppelin Tutorial/Basic Features (Spark)` notebook
    2. Change view mode to `report`.
    3. Change selected value from `married` to `single` in 5th paragraph and hit enter.
    4. See if paragraph runs
    
    ### Screenshots (if appropriate)
    ![jan-23-2017 14-14-05](https://cloud.githubusercontent.com/assets/8503346/22192310/460d713c-e176-11e6-96d4-96d25eb029c0.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? yes. docs update included.
    
    Author: Mina Lee <mi...@apache.org>
    
    Closes #1932 from minahlee/ZEPPELIN-2000 and squashes the following commits:
    
    a9f02d2 [Mina Lee] Update docs
    66b513c [Mina Lee] Run paragraph onEnter when select value changed
    
    (cherry picked from commit 7b7625db10eb6b0c49d58375b09d0dead9f4912d)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit cc666b5c3f59349c48b8a1009715313a5d8a2722
Author: Jeff Zhang <zj...@apache.org>
Date:   2017-01-23T06:30:44Z

    HOTFIX: Add the missing quotation for livy cancel
    
    ### What is this PR for?
    Seems I miss the quote when rebase. This cause the session recreation fails, I correct it in this PR.
    
    ### What type of PR is it?
    [Hot Fix |]
    
    ### Todos
    * [ ] - Task
    
    ### What is the Jira issue?
    No jira created, just minor change for hotfix
    
    ### How should this be tested?
    Tested manually
    
    ### Screenshots (if appropriate)
    ![image](https://cloud.githubusercontent.com/assets/164491/22193778/b8f960dc-e178-11e6-8595-b21f01ac62f9.png)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    
    Author: Jeff Zhang <zj...@apache.org>
    
    Closes #1933 from zjffdu/cancel_livy and squashes the following commits:
    
    d68b6cf [Jeff Zhang] HOTFIX: Add the missing quotes for livy cancel
    
    (cherry picked from commit 68e0b3813f77b3004859eda21506da90ac600fa3)
    Signed-off-by: Mina Lee <mi...@apache.org>

commit 48ad70e8c62975bdb00779bed5919eaca98c5b5d
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-24T01:05:54Z

    Preparing Apache Zeppelin release 0.7.0

commit d61e4bbd59fd20513a5c474342c21b219aca1002
Author: Mina Lee <mi...@apache.org>
Date:   2017-01-24T01:07:53Z

    Preparing development version 0.7.1-SNAPSHOT

commit 1961a9495019f324e312c322ca025236a6ca5df5
Author: AhyoungRyu <fb...@hanmail.net>
Date:   2017-01-02T17:25:18Z

    [ZEPPELIN-1880] Fix shell interpreter output streaming result
    
    ### What is this PR for?
    Shell interpreter streaming output had been available by #683, but currently it's broken after #1087 merged. This patch is for putting it back.
    
    ### What type of PR is it?
    Bug Fix
    
    ### TODO
    - [x] Fix test
    
    ### What is the Jira issue?
    [ZEPPELIN-1880](https://issues.apache.org/jira/browse/ZEPPELIN-1880)
    
    ### How should this be tested?
    ```
    %sh
    
    date && sleep 3 && date
    ```
    
    the each timestamp must be printed as streaming output
    
    ### Screenshots (if appropriate)
     - before
    ![shellintpresultbefore](https://cloud.githubusercontent.com/assets/10060731/21585515/60c35a04-d105-11e6-8e68-853ee784e89d.gif)
    
     - after
    ![shellintpresult](https://cloud.githubusercontent.com/assets/10060731/21585516/62142ac8-d105-11e6-8628-1d6eec35daae.gif)
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: AhyoungRyu <fb...@hanmail.net>
    
    Closes #1833 from AhyoungRyu/ZEPPELIN-1880 and squashes the following commits:
    
    8fe33c4 [AhyoungRyu] Fix invalid test cases
    e2fd4bf [AhyoungRyu] Add test for shell inpt timeout property
    34d3021 [AhyoungRyu] Fix shell intp streaming output result
    
    (cherry picked from commit 9b4a1bf72b46159f18bd11988bf7a448827f2b76)
    Signed-off-by: ahyoungryu <ah...@apache.org>

commit 143afe183d9541471682203667b1aa431ce7a1b0
Author: cloverhearts <cl...@gmail.com>
Date:   2017-01-20T21:38:17Z

    [ZEPPELIN-1921] missing close in closeAndRemoveInterpreterGroup method
    
    ### What is this PR for?
    The problem is that some code in the closeAndRemoveInterpreterGroup method of InterpreterSetting partially closes.
    
    ### What type of PR is it?
    Bug Fix
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-1921
    
    ### Questions:
    * Does the licenses files need update? no
    * Is there breaking changes for older versions? no
    * Does this needs documentation? no
    
    Author: cloverhearts <cl...@gmail.com>
    
    Closes #1864 from cloverhearts/ZEPPELIN-1921 and squashes the following commits:
    
    4ac76cf [cloverhearts] Merge branch 'master' into ZEPPELIN-1921
    f39212c [cloverhearts] fixed equals logic
    e21287f [cloverhearts] apply other side
    6b86dfd [cloverhearts] compare logic change
    6a2051c [cloverhearts] method name change (master rebase)
    d12ec57 [cloverhearts] missing brace
    ca9ecfd [cloverhearts] Merge branch 'master' into ZEPPELIN-1921
    22473a2 [cloverhearts] change return logic
    a105adf [cloverhearts] Merge branch 'master' into ZEPPELIN-1921
    b0a9396 [cloverhearts] test case and replace logic
    2482be6 [cloverhearts] container method -> isEqualInterpreterKey method
    e25f311 [cloverhearts] interpreter test case and replace logic
    546ee85 [cloverhearts] Revert "change Linkedlist to LinkedHashSet"
    59c9c76 [cloverhearts] implement testcase
    2188b1b [cloverhearts] change Linkedlist to LinkedHashSet
    0ebed44 [cloverhearts] fixed missing for close
    
    (cherry picked from commit 3bbcf0969749bfcfc3cb0a58a3af295a44959bd8)
    Signed-off-by: Jongyoul Lee <jo...@apache.org>

commit fbcbe6107d17616a5d2085414734d628e6ac7a18
Author: Beria <be...@qubole.com>
Date:   2016-05-06T04:32:02Z

    [ZEPPELIN-1983] Feedback about success/failure when interpreter is re…
    
    ### What is this PR for?
    When a interpreter is restarted, there is no feedback to user whether the action is received/honoured by zeppelin. This might also lead them to click restart multiple times, before they realize it has taken affect.
    Also fixed a null bug.
    
    ### What type of PR is it?
    [Improvement + Bug fix]
    
    ### Todos
    * None
    
    ### What is the Jira issue?
    ZEPPELIN-1983
    
    ### How should this be tested?
    Restart a interpreter to test the positive case. The message should disappers on its own after sometime if not closed. A simple way to test the negative case is to stop the server and then try restarting.
    
    ### Screenshots (if appropriate)
    #### Positive case
    ![positive case](https://cloud.githubusercontent.com/assets/4542030/22111327/fa675304-de84-11e6-9323-da49f2f70902.png)
    
    #### Negative case
    ![negative case](https://cloud.githubusercontent.com/assets/4542030/22111326/fa31bd84-de84-11e6-8a2e-07aaf0179275.png)
    
    ### Questions:
    * Does the licenses files need update?
    -No
    * Is there breaking changes for older versions?
    -No
    * Does this needs documentation?
    -No
    
    Author: Beria <be...@qubole.com>
    
    Closes #1914 from beriaanirudh/ZEPPELIN-1983 and squashes the following commits:
    
    761b986 [Beria] [ZEPPELIN-1983] Feedback about success/failure when interpreter is restarted

----


---

[GitHub] zeppelin issue #2611: Issues found through editing Note Permission

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2611
  
    Hi - if you have an issue, please report to our mailing list: https://zeppelin.apache.org/docs/0.7.3/development/howtocontribute.html#stay-involved
    



---

[GitHub] zeppelin pull request #2611: Issues found through editing Note Permission

Posted by big-loser <gi...@git.apache.org>.
Github user big-loser closed the pull request at:

    https://github.com/apache/zeppelin/pull/2611


---

[GitHub] zeppelin issue #2611: Issues found through editing Note Permission

Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:

    https://github.com/apache/zeppelin/pull/2611
  
    hmm? can you close this?


---