[jira] [Commented] (HBASE-24720) Meta replicas not cleaned when disabled

["Szabolcs Bukros (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-24720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17157570#comment-17157570 ] 

Szabolcs Bukros commented on HBASE-24720:
-----------------------------------------

Thanks for the merge and review [~psomogyi] !

> Meta replicas not cleaned when disabled
> ---------------------------------------
>
>                 Key: HBASE-24720
>                 URL: https://issues.apache.org/jira/browse/HBASE-24720
>             Project: HBase
>          Issue Type: Bug
>          Components: read replicas
>    Affects Versions: 3.0.0-alpha-1, 2.3.0, 2.4.0, 2.2.5
>            Reporter: Szabolcs Bukros
>            Assignee: Szabolcs Bukros
>            Priority: Minor
>             Fix For: 3.0.0-alpha-1, 2.3.1, 2.4.0, 2.2.6
>
>
> The assignMetaReplicas method works kinda like this:
> {code:java}
> void assignMetaReplicas(){
> if (numReplicas <= 1) return;
> //create if needed then assign meta replicas
> unassignExcessMetaReplica(numReplicas);
> }
> {code}
> Now this unassignExcessMetaReplica method is the one that gets rid of the replicas we no longer need. It closes them and deletes their zNode.  Unfortunately this only happens if we decreased the replica number. If we disabled it, by setting the replica number to 1 assignMetaReplicas returns instantly without cleaning up the no longer needed replicas resulting in replicas lingering around.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)