You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/26 06:10:16 UTC
[GitHub] [spark] dongjoon-hyun opened a new pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
dongjoon-hyun opened a new pull request #31338:
URL: https://github.com/apache/spark/pull/31338
### What changes were proposed in this pull request?
This is a follow-up of #31311 and fixes a typo in Scala 2.13 profile section in `publish-snapshot` command.
### Why are the changes needed?
To fix snapshot publishing for Scala 2.13.
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
Manual.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yuranos commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
yuranos commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-951237702
Ok then. Makes sense because I saw you were changing versions in the docs as well, and it was hard to believe you missed that.
Having said that - the [document](https://spark.apache.org/docs/latest/#downloading) still can be improved:
> For the Scala API, Spark 3.2.0 uses Scala 2.12. You will need to use a compatible Scala version (2.12.x).
3.2 is the first version that supports both 2.12 and 2.13. It's important to mention in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yuranos edited a comment on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
yuranos edited a comment on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-951237702
Ok then. Makes sense because I saw you were changing versions in the docs as well, and it was hard to believe you missed that.
Having said that - the [document](https://spark.apache.org/docs/latest/#downloading) can still be improved:
> For the Scala API, Spark 3.2.0 uses Scala 2.12. You will need to use a compatible Scala version (2.12.x).
3.2 is the first version that supports both 2.12 and 2.13. It's important to mention in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-767319952
Thank you so much!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-951625276
Ya, you are correct with that document part. We had better mention the availability of Scala 2.13.
Could you file a JIRA and PR for that, @yuranos ? Then, we can release it as a part of Apache Spark 3.2.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-951151079
No. Since Apache Spark's default Scala binary is still 2.12, `2.12` on documentation is correct.
We still publish all Spark document with Scala 2.12.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] yuranos commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
yuranos commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-950739895
@dongjoon-hyun , should the doc config var `SCALA_BINARY_VERSION` also be updated to `2.13`? https://github.com/apache/spark/blob/adbea252db0f61ed3aaa45ea20b704bad6c47408/docs/_config.yml#L24
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #31338:
URL: https://github.com/apache/spark/pull/31338
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-767319769
Merged to master.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #31338: [SPARK-34218][INFRA][FOLLOWUP] Fix Scala 2.13 profile typo in publish-snapshot
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #31338:
URL: https://github.com/apache/spark/pull/31338#issuecomment-767319860
Could you review this, @HyukjinKwon ? I missed this typo in the previous PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org