You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@gora.apache.org by AlexanderYastrebov <gi...@git.apache.org> on 2015/07/14 17:31:34 UTC

[GitHub] gora pull request: Disable cursor timeout

GitHub user AlexanderYastrebov opened a pull request:

    https://github.com/apache/gora/pull/27

    Disable cursor timeout

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/newpointer/gora disable_cursor_timeout

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/gora/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit ff903f5b4d6257e449ba4b0b2040d55f7217a660
Author: Alexander Yastrebov <ya...@gmail.com>
Date:   2015-07-14T15:08:31Z

    Disabled cursor timeout

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request: GORA-426 Disable cursor timeout

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/gora/pull/27


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request: GORA-426 Disable cursor timeout

Posted by drazzib <gi...@git.apache.org>.

Github user drazzib commented on the pull request:

    https://github.com/apache/gora/pull/27#issuecomment-125755956
  
    Hello @AlexanderYastrebov !
    
    After second thought and based on your reasoning (especially 2 and 3) I agree with you.
    I will merge this changes into master.
    
    Thanks for your contribution !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request: GORA-426 Disable cursor timeout

Posted by AlexanderYastrebov <gi...@git.apache.org>.

Github user AlexanderYastrebov commented on the pull request:

    https://github.com/apache/gora/pull/27#issuecomment-122774999
  
    Hello @drazzib 
    
    My point is following:
    1. If you have mean page parse time (in nutch) greater than 6 seconds, you will end up with closed cursor and failed parse run (because of default 100 batchSize and 10 min cursor timeout).
    2. There is no evidence at all (neither in API, not in docs) for lib user that cursor may be closed unexpectedly while reading result.
    3. (MongoDB)Result has close() method and with proper use there will leak no cursors.
    4. One more option to configure is worse than no option at all.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] gora pull request: GORA-426 Disable cursor timeout

Posted by drazzib <gi...@git.apache.org>.

Github user drazzib commented on the pull request:

    https://github.com/apache/gora/pull/27#issuecomment-122660179
  
    Hi @AlexanderYastrebov !
    
    I'm not sure that enforcing "QUERYOPTION_NOTIMEOUT" for all requests is the right way to fix this. I would at least prefer a way to allow configuration of this feature.
    
    Regards,


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---