[GitHub] [nifi] markap14 commented on a diff in pull request #6781: NIFI-10980 - correct ordering of property descriptor allowable values

[GitBox <gi...@apache.org>]

markap14 commented on code in PR #6781:
URL: https://github.com/apache/nifi/pull/6781#discussion_r1048488426


##########
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-api/pom.xml:
##########
@@ -426,5 +426,10 @@
             <artifactId>nifi-mock</artifactId>
             <scope>test</scope>
         </dependency>
+        <dependency>
+            <groupId>org.apache.nifi</groupId>
+            <artifactId>nifi-record-serialization-service-api</artifactId>
+            <scope>test</scope>
+        </dependency>

Review Comment:
   Is this brought in just for this line?
   ```
                   .identifiesControllerService(RecordReaderFactory.class)
   ```
   If so, I think we can eliminate the dependency and just use:
   ```
                   .identifiesControllerService(ControllerService.class)
   ```
   Would like to avoid bringing an extension's api nar into framework, even for tests, if not necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org