You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ab...@apache.org on 2003/04/10 12:51:44 UTC

cvs commit: maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates cvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xml maven-reports.xml project-info.xml team-list.xml

abarantsev    2003/04/10 03:51:44

  Added:       src/plugins-build/xdoc/src/plugin-resources/jelly-templates
                        cvs-usage.xml dependencies.xml index.xml
                        issue-tracking.xml mail-lists.xml maven-reports.xml
                        project-info.xml team-list.xml
  Log:
  Pure jelly reimplementation of Project Info templates
  
  Revision  Changes    Path
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/cvs-usage.xml
  
  Index: cvs-usage.xml
  ===================================================================
  <?xml version="1.0"?>
  <document xmlns:j="jelly:core">
    
    <properties>
      <author email="turbine-maven-dev@jakarta.apache.org">Maven</author>
      <title>CVS</title>
    </properties>
  
    <body>
      <j:set var="repository" value="${pom.repository}"/>
      
      <j:if test="${empty(repository)}">
        <section name="Repository">
          <p>
            No SCM repository is defined.
          </p>
        </section>
      </j:if>
      <j:if test="${!empty(repository)}">
      
      <j:set var="conn" value="${repository.cvsRoot}"/>
      <j:set var="module" value="${repository.cvsModule}"/>
      <j:set var="url" value="${repository.url}"/>
    
      <section name="Web Access">
        <p>
          <a href="${url}">${url}</a>
        </p>
      </section>
      
      <section name="Anonymous CVS Access">
        <p>
          This project's CVS repository can be checked out through anonymous (pserver)
          CVS with the following instruction set.
          When prompted for a password for anonymous, simply press the Enter key.
        </p>
        
        <p>
          cvs -d ${conn} login
          <br/>
          cvs -z3 -d ${conn} co ${module}
        </p>
  
        <p>
          Updates from within the module's directory do not need the -d parameter.
        </p>
      </section>
  
      <section name="Developer CVS Access via SSH">
  
        <p>
          Only project developers can access the CVS tree via this method.
          SSH1 must be installed on your client machine. Substitute   
          <b>name</b> with the proper value. Enter your site password when prompted.
        </p>
  
        <p>
          export CVS_RSH=ssh
          <br/>
          cvs -z3 -d ${conn} co ${module}
        </p>
  
      </section>
  
      <section name="CVS Access behind a firewall">
  
        <p>
          For those developers who are stuck behind a corporate
          firewall, <a href="http://cvsgrab.sourceforge.net/">CVSGrab</a>
          can use the viewcvs web interface to checkout the source code.
        </p>
  
      </section>
  
      </j:if>
    </body>
  
  </document>
  
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/dependencies.xml
  
  Index: dependencies.xml
  ===================================================================
  <?xml version="1.0"?>
  <document xmlns:j="jelly:core">
  
    <properties>
      <title>Dependencies</title>
    </properties>
  
    <body>
      <section name="Dependencies">
      <j:if test="${size(pom.dependencies) == 0}">
        <p> 
          There are no dependencies for this project.  It is a standalone
          application that does not depend on any other project.
        </p>
      </j:if>
      <j:if test="${size(pom.dependencies) != 0}">
        <p> 
          The following is a list of dependencies for this project.  These
          dependencies are required to compile and run the application:
        </p>
        <table>
          <tr>
            <th>ID</th>
            <th>Version</th>
            <th>JAR</th>
          </tr>
          <j:forEach var="dep" items="${pom.dependencies}">
          <tr>
            <td> 
              <j:if test="${!empty(dep.url)}">
                <a href="${dep.url}">${dep.groupId}</a> 
              </j:if>
              <j:if test="${empty(dep.url)}">
                ${dep.groupId}
              </j:if>
            </td>
            <td>${dep.version}</td>
            <td>${dep.artifact}</td>
          </tr>
          </j:forEach>
        </table>
      </j:if>
      </section>
    </body>
  </document>
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/index.xml
  
  Index: index.xml
  ===================================================================
  <?xml version="1.0"?>
  <document>
  
    <properties>
      <title>${pom.name}</title>
    </properties>
  
    <body>
      <section name="${pom.name}">
        <p>
          ${pom.description}
        </p>
      </section>
    </body>
  </document>
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/issue-tracking.xml
  
  Index: issue-tracking.xml
  ===================================================================
  <?xml version="1.0"?>
  <document>
    
    <properties>
      <author email="turbine-maven-dev@jakarta.apache.org">Maven</author>
      <title>Issue Tracking</title>
    </properties>
  
    <body>
      <section name="Issue Tracking">
        <p>
          <a href="${pom.issueTrackingUrl}">${pom.issueTrackingUrl}</a>
        </p>
      </section>
    </body>
  </document>
  
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/mail-lists.xml
  
  Index: mail-lists.xml
  ===================================================================
  <?xml version="1.0"?>
  <document xmlns:j="jelly:core" xmlns:define="jelly:define" xmlns:myMacros="myMacros">
  
  <define:taglib uri="myMacros">
  <define:tag name="displayLink">
  <td>
    <j:if test="${!empty(link)}">
      <j:if test="${link.startsWith('http')}">
        <a href="${link}">${label}</a>
      </j:if>
      <j:if test="${!link.startsWith('http')}">
        <a href="mailto:${link}">${label}</a>
      </j:if>
    </j:if>
    <j:if test="${empty(link)}">
      Not Available
    </j:if>
  </td>
  </define:tag>
  </define:taglib>
  
    <properties>
      <title>Mailing Lists</title>
    </properties>
  
    <body>
      <section name="Mailing Lists">
      <j:if test="${size(pom.mailingLists) == 0}">
        <p> 
          There are no mailing lists established for this project.  Please
          check back at a later date.
        </p>
      </j:if>
      <j:if test="${size(pom.mailingLists) != 0}">
        <p> 
          These are the mailing lists that have been established for this
          project.  For each list, there is a subscribe, unsubscribe, and an
          archive link.
        </p>
        <table>
          <tr>
            <th>List Name</th>
            <th>Subscribe</th>
            <th>Unsubscribe</th>
            <th>Archive</th>
          </tr>
          <j:forEach var="list" items="${pom.mailingLists}">
          <tr>
            <td>${list.name}</td>
            <myMacros:displayLink label="Subscribe" link="${list.subscribe}"/>
            <myMacros:displayLink label="Unsubscribe" link="${list.unsubscribe}"/>
            <myMacros:displayLink label="Archive" link="${list.archive}"/>
          </tr>
          </j:forEach>
        </table>
      </j:if>
      </section>
    </body>
  </document>
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/maven-reports.xml
  
  Index: maven-reports.xml
  ===================================================================
  <?xml version="1.0"?>
  <document xmlns:j="jelly:core">
  
    <properties>
      <title>Project Reports</title>
      <author email="pete-apache-dev@kazmier.com">Pete Kazmier</author>
    </properties>
  
    <body>
      <section name="Maven Generated Reports">
        <p>
          This document provides an overview of the various reports that
          are automatically generated by 
          <a href="http://maven.apache.org/">Maven</a>.
          Each report is briefly described below.
        </p>
  
      <j:set var="reports" value="${pom.getPluginContext('maven-xdoc-plugin').getVariable('reports')}"/>
      <subsection name="Overview">
          <table>
            <tr><th>Document</th><th>Description</th></tr>
            <j:forEach var="report" items="${reports}">
            <tr>
              <td><a href="${report.link}.html">${report.name}</a></td>
              <td>${report.description}</td>
            </tr>
            </j:forEach>
          </table>
        </subsection>
      </section>
   </body>
  </document>
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/project-info.xml
  
  Index: project-info.xml
  ===================================================================
  <?xml version="1.0"?>
  <document xmlns:j="jelly:core">
  
    <properties>
      <title>Project Information</title>
      <author email="pete-apache-dev@kazmier.com">Pete Kazmier</author>
    </properties>
  
    <body>
      <section name="General Project Information">
        <p>
          This document provides an overview of the various documents and
          links that are part of this project's general information.  All
          of this content is automatically generated by 
          <a href="http://maven.apache.org/">Maven</a> on
          behalf of the project.
        </p>
  
        <subsection name="Overview">
          <table>
            <tr><th>Document</th><th>Description</th></tr>
            <tr><td><a href="mail-lists.html">Mailing Lists</a></td>
              <td>
                This document provides subscription and archive
                information for this project's mailing lists.
              </td>
            </tr>
            <tr><td><a href="team-list.html">Project Team</a></td>
              <td>
                This document provides information on the members of
                this project.  These are the individuals who have
                contributed to the project in one form or another.
              </td>
            </tr>
            <tr><td><a href="dependencies.html">Dependencies</a></td>
              <td>
                This document lists the projects dependencies and provides
                information on each dependency.
              </td>
            </tr>
            
            <!-- 
            
            This is really bad that the url requires specification in two
            places. Makes pluggable reporting impossible. FIX
            
            -->
            
            <j:if test="${!empty(pom.repository.url)}">
            <tr><td><a href="cvs-usage.html">Source Repository</a></td>
              <td>
                This is a link to the online source repository that can be
                viewed via a web browser.
              </td>
            </tr>
            </j:if>
            <j:if test="${!empty(pom.issueTrackingUrl)}">
            <tr><td><a href="issue-tracking.html">Issue Tracking</a></td>
              <td>
                This is a link to the issue tracking system for this
                project.  Issues (bugs, features, change requests) can be
                created and queried using this link.
              </td>
            </tr>
            </j:if>
          </table>
        </subsection>
      </section>
   </body>
  </document>
  
  
  
  1.1                  maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates/team-list.xml
  
  Index: team-list.xml
  ===================================================================
  <?xml version="1.0" encoding="ISO-8859-1" ?>
  <document xmlns:j="jelly:core">
  
    <properties>
      <title>Project Team</title>
    </properties>
  
    <body>
  
      <section name="The Team">
        <p>
          A successful project requires many people to play many roles.
          Some members write code or documentation, while others are
          valuable as testers, submitting patches and suggestions.
        </p>
  
        <p>
          The team is comprised of <a href="#Members">Members</a>
          and <a href="#Contributors">Contributors</a>.  Members 
          have direct access to the source of a project and actively
          evolve the code-base.  Contributors improve the project
          through submission of patches and suggestions to the Members.
          The number of Contributors to the project is unbounded.
          Get involved today.  All contributions to the project are
          greatly appreciated.
        </p>
      </section>
  
      <section name="Members">
      <j:if test="${size(pom.developers) == 0}">
        <p>
          There are no developers working on this project.  Please check
          back at a later date.
        </p>
      </j:if>
      <j:if test="${size(pom.developers) != 0}">
        <p>
          The following is a list of developers with commit privileges that have 
          directly contributed to the project in one way or another.  
        </p>
        <table>
          <tr>
            <th>Name</th>
            <th>Id</th>
            <th>Email</th>
            <th>Organization</th>
            <th>Roles</th>
          </tr>
          <j:forEach var="developer" items="${pom.developers}">
          <tr>
            <j:if test="${!empty(developer.url)}">
            <td><a href="${developer.url}">${developer.name}</a></td>
            </j:if>
            <j:if test="${empty(developer.url)}">
            <td>${developer.name}</td>
            </j:if>
            <td><a name="${developer.id}">${developer.id}</a></td>
            <td><a href="mailto:${developer.email}">${developer.email}</a></td>
            <td>${developer.organization}</td>
            <td>
            <j:forEach var="role" items="${developer.roles}">
            ${role}<br/>
            </j:forEach>
            </td>
          </tr>
          </j:forEach>
        </table>
      </j:if>
      <j:if test="${size(pom.contributors) != 0}">
        <section name="Contributors">
        <p>
        The following additional people have contributed to this project
        through the way of suggestions, patches or documentation.
        </p>
        <table>
          <tr>
            <th>Name</th>
            <th>Email</th>
            <th>Organization</th>
            <th>Roles</th>
          </tr>
          <j:forEach var="contributor" items="${pom.contributors}">
          <tr>
            <td>${contributor.name}</td>
            <td><a href="mailto:${contributor.email}">${contributor.email}</a></td>
            <td>${contributor.organization}</td>
            <td>
            <j:forEach var="role" items="${contributor.roles}">
            ${role}<br/>
            </j:forEach>
            </td>
          </tr>
          </j:forEach>
        </table>
        </section>
      </j:if>
      </section>
    </body>
  </document>
  
  
  

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Changelog plugin and "six tokens"

Posted by Ben Walding <de...@walding.com>.
Thanks Florin,

I'm considering rejigging a few parts of the connection parsing to make 
it easier to test and use.  It'll be done in the next day or two.

MAVEN-383 raised to fix this problem

Cheers,


Ben

Florin Vancea wrote:

>And yet, still.
>
>The docs for the project.xml structure states very clearly that the
>connection string has to start with "scm" and also states that the next
>character is the delimiter (which is a cool thing to do, btw).
>The changelog implements this, but the org.apache.maven.project.Repository
>class in main Maven sources fail do do so and uses ":" as the hardcoded
>separator. This induces a failure in generated docs, at least in the
>cvs-usage page, when the separator is not ":", as required for Windows CVS
>users.
>
>Here is a patch against the HEAD for
>src/java/org/apache/maven/project/Repository.java.
>It's the output from cvs diff between the HEAD version (which is 1.1.1.1 in
>my local Maven CVS) and the patched version.
>I'm mentioning this since I have no experience producing usable patch diff
>files on Windows. I hope it's usable.
>
>====== Diff starts here =============
>RCS file:
>w:/cvs/osp/maven/src/java/org/apache/maven/project/Repository.java,v
>retrieving revision 1.1.1.1
>diff -r1.1.1.1 Repository.java
>128c128
><             return getConnection().substring( 0, connection.lastIndexOf(
>":" ) ).substring( 7 );
>---
>  
>
>>            return getConnection().substring( 0, connection.lastIndexOf(
>>    
>>
>getSeparator() ) ).substring( 7 );
>143c143
><             return getConnection().substring( connection.lastIndexOf(
>":" ) + 1 );
>---
>  
>
>>            return getConnection().substring( connection.lastIndexOf(
>>    
>>
>getSeparator() ) + 1 );
>146a147,164
>  
>
>>    }
>>
>>    /**
>>     * Get separator (char after "scm" prefix)
>>     *
>>     * TODO: Check that connection string really starts with "scm", like
>>    
>>
>in changelog plugin
>  
>
>>     * @return separator
>>     */
>>    private String getSeparator()
>>    {
>>        if ( isValid( getConnection() ) )
>>        {
>>            return getConnection().substring( 3, 4 );
>>        }
>>        else
>>        {
>>            return ":";
>>        }
>>    
>>
>====== Diff ends here =============
>
>Florin
>
>----- Original Message -----
>From: "Florin Vancea" <fv...@maxiq.ro>
>To: "Maven Developers List" <de...@maven.apache.org>
>Sent: Thursday, April 10, 2003 5:57 PM
>Subject: Re: Changelog plugin and "six tokens"
>
>
>  
>
>>Oops, sorry for jumping the gun.
>>I saw the light after reading the source. And after that I found the docs,
>>too :)
>>
>>Sorry again.
>>
>>----- Original Message -----
>>From: "Florin Vancea" <fv...@maxiq.ro>
>>To: "Maven Developers List" <de...@maven.apache.org>
>>Sent: Thursday, April 10, 2003 4:41 PM
>>Subject: Changelog plugin and "six tokens"
>>
>>
>>    
>>
>>>Hello all.
>>>
>>>The changelog plugin seems to require now that the repository connection
>>>string is composed of at most 6 tokens.
>>>I am running my CVS server on a Windows machine and the fifth token must
>>>      
>>>
>>be
>>    
>>
>>>something like "w:/cvs/repodir".
>>>Notice the colon after "w".
>>>Of course the plugin complains, but I do not know any way to represent
>>>      
>>>
>the
>  
>
>>>path without the drive letter.
>>>
>>>As I recall now, the changelog plugin never worked, but I never really
>>>bothered to find out why.
>>>Now I realize that "w" was interpreted as the fifth token (i.e. the
>>>      
>>>
>path)
>  
>
>>>and "/cvs/repodir" was taken to be the module name.
>>>The module itself was blown away, until this check.
>>>
>>>Anyone using CVS on Windows? Any suggestions? (aside from moving to
>>>      
>>>
>Linux
>  
>
>>or
>>    
>>
>>>the like :) )
>>>Is this solvable within the current architecture of the changelog
>>>      
>>>
>plugin?
>  
>
>>>Thanks,
>>>Florin
>>>
>>>
>>>
>>>---------------------------------------------------------------------
>>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>>For additional commands, e-mail: dev-help@maven.apache.org
>>>
>>>
>>>      
>>>
>>
>>---------------------------------------------------------------------
>>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>>For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
>>    
>>
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Changelog plugin and "six tokens"

Posted by Florin Vancea <fv...@maxiq.ro>.
And yet, still.

The docs for the project.xml structure states very clearly that the
connection string has to start with "scm" and also states that the next
character is the delimiter (which is a cool thing to do, btw).
The changelog implements this, but the org.apache.maven.project.Repository
class in main Maven sources fail do do so and uses ":" as the hardcoded
separator. This induces a failure in generated docs, at least in the
cvs-usage page, when the separator is not ":", as required for Windows CVS
users.

Here is a patch against the HEAD for
src/java/org/apache/maven/project/Repository.java.
It's the output from cvs diff between the HEAD version (which is 1.1.1.1 in
my local Maven CVS) and the patched version.
I'm mentioning this since I have no experience producing usable patch diff
files on Windows. I hope it's usable.

====== Diff starts here =============
RCS file:
w:/cvs/osp/maven/src/java/org/apache/maven/project/Repository.java,v
retrieving revision 1.1.1.1
diff -r1.1.1.1 Repository.java
128c128
<             return getConnection().substring( 0, connection.lastIndexOf(
":" ) ).substring( 7 );
---
>             return getConnection().substring( 0, connection.lastIndexOf(
getSeparator() ) ).substring( 7 );
143c143
<             return getConnection().substring( connection.lastIndexOf(
":" ) + 1 );
---
>             return getConnection().substring( connection.lastIndexOf(
getSeparator() ) + 1 );
146a147,164
>     }
>
>     /**
>      * Get separator (char after "scm" prefix)
>      *
>      * TODO: Check that connection string really starts with "scm", like
in changelog plugin
>      * @return separator
>      */
>     private String getSeparator()
>     {
>         if ( isValid( getConnection() ) )
>         {
>             return getConnection().substring( 3, 4 );
>         }
>         else
>         {
>             return ":";
>         }
====== Diff ends here =============

Florin

----- Original Message -----
From: "Florin Vancea" <fv...@maxiq.ro>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Thursday, April 10, 2003 5:57 PM
Subject: Re: Changelog plugin and "six tokens"


> Oops, sorry for jumping the gun.
> I saw the light after reading the source. And after that I found the docs,
> too :)
>
> Sorry again.
>
> ----- Original Message -----
> From: "Florin Vancea" <fv...@maxiq.ro>
> To: "Maven Developers List" <de...@maven.apache.org>
> Sent: Thursday, April 10, 2003 4:41 PM
> Subject: Changelog plugin and "six tokens"
>
>
> > Hello all.
> >
> > The changelog plugin seems to require now that the repository connection
> > string is composed of at most 6 tokens.
> > I am running my CVS server on a Windows machine and the fifth token must
> be
> > something like "w:/cvs/repodir".
> > Notice the colon after "w".
> > Of course the plugin complains, but I do not know any way to represent
the
> > path without the drive letter.
> >
> > As I recall now, the changelog plugin never worked, but I never really
> > bothered to find out why.
> > Now I realize that "w" was interpreted as the fifth token (i.e. the
path)
> > and "/cvs/repodir" was taken to be the module name.
> > The module itself was blown away, until this check.
> >
> > Anyone using CVS on Windows? Any suggestions? (aside from moving to
Linux
> or
> > the like :) )
> > Is this solvable within the current architecture of the changelog
plugin?
> >
> > Thanks,
> > Florin
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: Changelog plugin and "six tokens"

Posted by Florin Vancea <fv...@maxiq.ro>.
Oops, sorry for jumping the gun.
I saw the light after reading the source. And after that I found the docs,
too :)

Sorry again.

----- Original Message -----
From: "Florin Vancea" <fv...@maxiq.ro>
To: "Maven Developers List" <de...@maven.apache.org>
Sent: Thursday, April 10, 2003 4:41 PM
Subject: Changelog plugin and "six tokens"


> Hello all.
>
> The changelog plugin seems to require now that the repository connection
> string is composed of at most 6 tokens.
> I am running my CVS server on a Windows machine and the fifth token must
be
> something like "w:/cvs/repodir".
> Notice the colon after "w".
> Of course the plugin complains, but I do not know any way to represent the
> path without the drive letter.
>
> As I recall now, the changelog plugin never worked, but I never really
> bothered to find out why.
> Now I realize that "w" was interpreted as the fifth token (i.e. the path)
> and "/cvs/repodir" was taken to be the module name.
> The module itself was blown away, until this check.
>
> Anyone using CVS on Windows? Any suggestions? (aside from moving to Linux
or
> the like :) )
> Is this solvable within the current architecture of the changelog plugin?
>
> Thanks,
> Florin
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Changelog plugin and "six tokens"

Posted by Florin Vancea <fv...@maxiq.ro>.
Hello all.

The changelog plugin seems to require now that the repository connection
string is composed of at most 6 tokens.
I am running my CVS server on a Windows machine and the fifth token must be
something like "w:/cvs/repodir".
Notice the colon after "w".
Of course the plugin complains, but I do not know any way to represent the
path without the drive letter.

As I recall now, the changelog plugin never worked, but I never really
bothered to find out why.
Now I realize that "w" was interpreted as the fifth token (i.e. the path)
and "/cvs/repodir" was taken to be the module name.
The module itself was blown away, until this check.

Anyone using CVS on Windows? Any suggestions? (aside from moving to Linux or
the like :) )
Is this solvable within the current architecture of the changelog plugin?

Thanks,
Florin



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit: maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates cvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xml maven-reports.xml project-info.xml team-list.xml

Posted by Pete Kazmier <pe...@kazmier.com>.
Jason van Zyl <ja...@zenplex.com> writes:

> Why did you reimplement these in Jelly? I like the Velocity templates,
> any particular reason for changing them?

I agree with Jason.

The Velocity templates were created to avoid the non-sense of JSL and
DVSL.  In fact, these particular templates were one of the primary
reasons that the Velocity taglib was created.  Velocity is a template
engine, designed to merge a context with a template, using a simple
language to do so.  Why complicate the situation with JSL?  Besides,
IMHO, Velocity templates are *much* easier to read.

I'm curious as to Alexei's motivation.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templatescvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xmlmaven-reports.xml project-info.xml team-list.xml

Posted by Jason van Zyl <ja...@zenplex.com>.
On Thu, 2003-04-10 at 14:08, Pete Kazmier wrote:
> "Alexei Barantsev" <ba...@kazbek.ispras.ru> writes:
> 
> > To argue Jelly advantages over Velocity in this case
> > I can provide the following profiling results.
> >
> > Difference is not very much, but it grows if you run big reactored
> > project.
> 
> As we just discovered, Alexei was a bit confused as to what Velocity
> was actually used for in Maven.  It seems that he was confusing DVSL
> with the Velocity Jelly taglib which are two entirely different
> things.  The Velocity taglib is not used significantly when generating
> a site.
> 
> I think we can safely delete the Jelly versions of those templates now
> that we are all in agreement.

Yes, I would prefer to keep the Velocity templates :-)

> -Pete
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templatescvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xmlmaven-reports.xml project-info.xml team-list.xml

Posted by Ben Walding <de...@walding.com>.
I'm going to look into this this weekend (yeah I'm no-life Ben - 
actually I'm no-car Ben, it arrives on Monday).

Alexei Barantsev wrote:

>What we discovered about my ignorance and unawareness
>does not discredit result of performance measurement :)
>
>Another example. I tried to generate maven site with plugins.
>I set MAVEN_DEFAULT_OPTS="-Xmx320m".
>Certainly, generation was not completed - it ran out of memory.
>(btw, what memory is enough to generate the full site?)
>
>I tries to run it twice - with Jelly templates and with Velocity ones.
>Jelly chewed two more plugins.
>
>Our processing order:
>Maven Ant Plug-in
>Maven EAR Plugin
>Maven Antlr Plugin
>Maven Appserver Plugin
>Maven Ashkelon Plug-in
>Maven AspectJ Plug-in
>Maven Cactus Plug-in
>Maven Castor Plug-in
>Maven Changelog Plug-in
>Maven Changes Plug-in
>Maven Checkstyle Plug-in
>Maven Clover Plug-in
>Maven CodeSwitcher Plugin
>Maven Console Plug-in
>Maven Deploy Plug-in
>Maven Developer Activity Plug-in
>Maven Distribution Plug-in
>Maven DocBook Plug-in
>.... [tail skipped]
>
>Jelly:
>+----------------------------------------
>| Generating site for Maven Distribution Plug-in
>| Memory: 312M/317M
>+----------------------------------------
>... [here generation was stopped]
>
>Velocity:
>+----------------------------------------
>| Generating site for Maven Deploy Plug-in
>| Memory: 315M/317M
>+----------------------------------------
>... [here generation was stopped]
>
>  
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: cvs commit:maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templatescvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xmlmaven-reports.xml project-info.xml team-list.xml

Posted by Alexei Barantsev <ba...@kazbek.ispras.ru>.
What we discovered about my ignorance and unawareness
does not discredit result of performance measurement :)

Another example. I tried to generate maven site with plugins.
I set MAVEN_DEFAULT_OPTS="-Xmx320m".
Certainly, generation was not completed - it ran out of memory.
(btw, what memory is enough to generate the full site?)

I tries to run it twice - with Jelly templates and with Velocity ones.
Jelly chewed two more plugins.

Our processing order:
Maven Ant Plug-in
Maven EAR Plugin
Maven Antlr Plugin
Maven Appserver Plugin
Maven Ashkelon Plug-in
Maven AspectJ Plug-in
Maven Cactus Plug-in
Maven Castor Plug-in
Maven Changelog Plug-in
Maven Changes Plug-in
Maven Checkstyle Plug-in
Maven Clover Plug-in
Maven CodeSwitcher Plugin
Maven Console Plug-in
Maven Deploy Plug-in
Maven Developer Activity Plug-in
Maven Distribution Plug-in
Maven DocBook Plug-in
.... [tail skipped]

Jelly:
+----------------------------------------
| Generating site for Maven Distribution Plug-in
| Memory: 312M/317M
+----------------------------------------
... [here generation was stopped]

Velocity:
+----------------------------------------
| Generating site for Maven Deploy Plug-in
| Memory: 315M/317M
+----------------------------------------
... [here generation was stopped]

-- 
Alexei Barantsev, ISP RAS
E-mail: barancev@kazbek.ispras.ru
ICQ   : 3959207

  > -----Original Message-----
  > From: Pete Kazmier [mailto:pete@kazmier.com] 
  > Sent: Thursday, April 10, 2003 10:08 PM
  > To: Maven Developers List
  > Subject: Re: cvs 
  > commit:maven/src/plugins-build/xdoc/src/plugin-resources/jel
  > ly-templatescvs-usage.xml dependencies.xml index.xml 
  > issue-tracking.xml mail-lists.xmlmaven-reports.xml 
  > project-info.xml team-list.xml
  > 
  > 
  > "Alexei Barantsev" <ba...@kazbek.ispras.ru> writes:
  > 
  > > To argue Jelly advantages over Velocity in this case
  > > I can provide the following profiling results.
  > >
  > > Difference is not very much, but it grows if you run big 
  > reactored 
  > > project.
  > 
  > As we just discovered, Alexei was a bit confused as to what 
  > Velocity was actually used for in Maven.  It seems that he 
  > was confusing DVSL with the Velocity Jelly taglib which are 
  > two entirely different things.  The Velocity taglib is not 
  > used significantly when generating a site.
  > 
  > I think we can safely delete the Jelly versions of those 
  > templates now that we are all in agreement.
  > 
  > -Pete
  > 
  > ------------------------------------------------------------
  > ---------
  > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
  > For additional commands, e-mail: dev-help@maven.apache.org
  > 
  > 
  > 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit:maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templatescvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xmlmaven-reports.xml project-info.xml team-list.xml

Posted by Pete Kazmier <pe...@kazmier.com>.
"Alexei Barantsev" <ba...@kazbek.ispras.ru> writes:

> To argue Jelly advantages over Velocity in this case
> I can provide the following profiling results.
>
> Difference is not very much, but it grows if you run big reactored
> project.

As we just discovered, Alexei was a bit confused as to what Velocity
was actually used for in Maven.  It seems that he was confusing DVSL
with the Velocity Jelly taglib which are two entirely different
things.  The Velocity taglib is not used significantly when generating
a site.

I think we can safely delete the Jelly versions of those templates now
that we are all in agreement.

-Pete

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


RE: cvs commit:maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templatescvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xmlmaven-reports.xml project-info.xml team-list.xml

Posted by Alexei Barantsev <ba...@kazbek.ispras.ru>.
To argue Jelly advantages over Velocity in this case
I can provide the following profiling results.

Difference is not very much, but it grows if you run big reactored
project.

All data was obtained from generation of xdoc for maven:
maven xdoc:generate-from-pom

1. Timing: -Xprof

Velocity:
Flat profile of 6.48 secs (367 total ticks): main
Jelly:
Flat profile of 6.01 secs (353 total ticks): main

2. Heap memory: -Xrunhprof

Velocity:
HEAP DUMP BEGIN (221205 objects, 12720984 bytes) Thu Apr 10 21:52:15
2003
Jelly:
HEAP DUMP BEGIN (238807 objects, 11176624 bytes) Thu Apr 10 21:49:14
2003

3. Process peak memory:

Velocity: 30M
Jelly: 27M

-- 
Alexei Barantsev, ISP RAS
E-mail: barancev@kazbek.ispras.ru
ICQ   : 3959207


  > -----Original Message-----
  > From: Jason van Zyl [mailto:jason@zenplex.com] 
  > Sent: Thursday, April 10, 2003 5:17 PM
  > To: Maven Developers List
  > Subject: Re: cvs 
  > commit:maven/src/plugins-build/xdoc/src/plugin-resources/jel
  > ly-templatescvs-usage.xml dependencies.xml index.xml 
  > issue-tracking.xml mail-lists.xmlmaven-reports.xml 
  > project-info.xml team-list.xml
  > 
  > 
  > On Thu, 2003-04-10 at 06:51, abarantsev@apache.org wrote:
  > > abarantsev    2003/04/10 03:51:44
  > > 
  > >   Added:       
  > src/plugins-build/xdoc/src/plugin-resources/jelly-templates
  > >                         cvs-usage.xml dependencies.xml index.xml
  > >                         issue-tracking.xml mail-lists.xml 
  > maven-reports.xml
  > >                         project-info.xml team-list.xml
  > >   Log:
  > >   Pure jelly reimplementation of Project Info templates
  > 
  > Why did you reimplement these in Jelly? I like the Velocity 
  > templates, any particular reason for changing them?
  >   
  > 
  > -- 
  > jvz.
  > 
  > Jason van Zyl
  > jason@zenplex.com
  > http://tambora.zenplex.org
  > 
  > In short, man creates for himself a new religion of a 
  > rational and technical order to justify his work and to be 
  > justified in it.
  >   
  >   -- Jacques Ellul, The Technological Society
  > 
  > 
  > ------------------------------------------------------------
  > ---------
  > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
  > For additional commands, e-mail: dev-help@maven.apache.org
  > 
  > 
  > 




---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org


Re: cvs commit: maven/src/plugins-build/xdoc/src/plugin-resources/jelly-templates cvs-usage.xml dependencies.xml index.xml issue-tracking.xml mail-lists.xml maven-reports.xml project-info.xml team-list.xml

Posted by Jason van Zyl <ja...@zenplex.com>.
On Thu, 2003-04-10 at 06:51, abarantsev@apache.org wrote:
> abarantsev    2003/04/10 03:51:44
> 
>   Added:       src/plugins-build/xdoc/src/plugin-resources/jelly-templates
>                         cvs-usage.xml dependencies.xml index.xml
>                         issue-tracking.xml mail-lists.xml maven-reports.xml
>                         project-info.xml team-list.xml
>   Log:
>   Pure jelly reimplementation of Project Info templates

Why did you reimplement these in Jelly? I like the Velocity templates,
any particular reason for changing them?
  

-- 
jvz.

Jason van Zyl
jason@zenplex.com
http://tambora.zenplex.org

In short, man creates for himself a new religion of a rational
and technical order to justify his work and to be justified in it.
  
  -- Jacques Ellul, The Technological Society


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org