You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bookkeeper.apache.org by sh...@apache.org on 2024/04/09 08:39:11 UTC

(bookkeeper) branch master updated: Remove unused journaltime (#4006)

This is an automated email from the ASF dual-hosted git repository.

shoothzj pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/bookkeeper.git


The following commit(s) were added to refs/heads/master by this push:
     new 75dcd6fa27 Remove unused journaltime (#4006)
75dcd6fa27 is described below

commit 75dcd6fa274d1f981be4a3593ea9d7c76c9e8cb2
Author: Zhangao <ga...@qq.com>
AuthorDate: Tue Apr 9 16:39:06 2024 +0800

    Remove unused journaltime (#4006)
    
    ### Motivation
    
    journalTime metric is unused anymore  since #3843
    
    ### Changes
    
    Remove journalTime
    Co-authored-by: gavingaozhangmin <ga...@didiglobal.com>
---
 .../src/main/java/org/apache/bookkeeper/bookie/Journal.java           | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
index df10dfe522..41591eb82b 100644
--- a/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
+++ b/bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/Journal.java
@@ -628,7 +628,6 @@ public class Journal implements CheckpointSource {
     private final String lastMarkFileName;
 
     private final Counter callbackTime;
-    private final Counter journalTime;
     private static final String journalThreadName = "BookieJournal";
 
     // journal entry queue to commit
@@ -689,9 +688,6 @@ public class Journal implements CheckpointSource {
         this.journalPageCacheFlushIntervalMSec = conf.getJournalPageCacheFlushIntervalMSec();
         this.journalReuseFiles = conf.getJournalReuseFiles();
         this.callbackTime = journalStatsLogger.getThreadScopedCounter("callback-time");
-
-        this.journalTime = journalStatsLogger.getThreadScopedCounter("journal-thread-time");
-
         // Unless there is a cap on the max wait (which requires group force writes)
         // we cannot skip flushing for queue empty
         this.flushWhenQueueEmpty = maxGroupWaitInNanos <= 0 || conf.getJournalFlushWhenQueueEmpty();