You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/09/08 07:05:26 UTC

[GitHub] zeppelin pull request #2573: [ZEPPELIN-2920] move commonly used error handle...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2573

    [ZEPPELIN-2920] move commonly used error handlers to util (FRONT)

    ### What is this PR for?
    
    Sometimes I can see manually written error handler and it's repeated again and again.
    Even sometimes I can see missing 401 (unauthorized error) handler. So I propose here generalizing error handler for frontend. 
    
    ### What type of PR is it?
    [Improvement | Refactoring]
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2920](https://issues.apache.org/jira/browse/ZEPPELIN-2920)
    
    ### How should this be tested?
    
    Add `error-handler.service.test.js` and CI will test it.
    If you can test manually, u can easily reproduce errornous respsone by toggling offline in chrome developer tool like. 
    
    ![image](https://user-images.githubusercontent.com/4968473/30199834-6534160a-94af-11e7-9685-719b74e9fa50.png)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2920/refactor-add-error-handler-service

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2573.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2573
    
----
commit 3ca554e02cf87e7e7e21f1734b516de82b0c30e7
Author: 1ambda <1a...@gmail.com>
Date:   2017-09-08T07:00:29Z

    fix: Add error-handler service

commit 1a8142bfb834b6abdc80e73055f2cbd0166eaab7
Author: 1ambda <1a...@gmail.com>
Date:   2017-09-08T07:00:36Z

    fix: Apply error-handler service

----


---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2573
  
    rebased since it's quite old


---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2573
  
    CI failed but irrelevant
    
    ```
    Failed tests: 
      RemoteInterpreterServerTest.testStartStop:62 expected:<true> but was:<false>
    ```
    
    - https://s3.amazonaws.com/archive.travis-ci.org/jobs/273195461/log.txt?X-Amz-Expires=30&X-Amz-Date=20170909T042527Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20170909/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=92cb9be0c7d2f3504f8a989203f575f4401baeeb029b4ee48fead89b93e6c2cb


---

[GitHub] zeppelin pull request #2573: [ZEPPELIN-2920] move commonly used error handle...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2573


---

[GitHub] zeppelin issue #2573: [ZEPPELIN-2920] move commonly used error handlers to u...

Posted by 1ambda <gi...@git.apache.org>.
Github user 1ambda commented on the issue:

    https://github.com/apache/zeppelin/pull/2573
  
    - https://travis-ci.org/1ambda/zeppelin/jobs/286465199
    - https://s3.amazonaws.com/archive.travis-ci.org/jobs/286465199/log.txt?X-Amz-Expires=30&X-Amz-Date=20171011T113958Z&X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAJRYRXRSVGNKPKO5A/20171011/us-east-1/s3/aws4_request&X-Amz-SignedHeaders=host&X-Amz-Signature=15e71aa2c61cf1ee2f241e91b3d4ab31c47293888f81b865603c6d3171142ad4
    
    ```
    [INFO] **************************************************
    [INFO] *                    Failures                    *
    [INFO] **************************************************
    [INFO] 
    [INFO] 1) Search block e2e Test counter increase and decrease correctly
    [INFO]   - Expected false to be true.
    [INFO]   - Expected false to be true.
    [INFO]   - Expected false to be true.
    [INFO]   - Expected false to be true.
    ```


---