You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by "Ted Xu (JIRA)" <ji...@apache.org> on 2011/02/10 11:29:57 UTC

[jira] Created: (HIVE-1982) Group by key shall not duplicate with distinct key

Group by key shall not duplicate with distinct key
--------------------------------------------------

                 Key: HIVE-1982
                 URL: https://issues.apache.org/jira/browse/HIVE-1982
             Project: Hive
          Issue Type: Bug
    Affects Versions: 0.6.0, 0.7.0
            Reporter: Ted Xu
            Assignee: Ted Xu
            Priority: Minor


Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994907#comment-12994907 ] 

He Yongqiang commented on HIVE-1982:
------------------------------------

Ted, how difficult do you think it is to fix the underlying problem? some ideas?

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Namit Jain (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Namit Jain reassigned HIVE-1982:
--------------------------------

    Assignee: Ted Xu

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Status: Patch Available  (was: Open)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993206#comment-12993206 ] 

He Yongqiang commented on HIVE-1982:
------------------------------------

will take a look.

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Assigned: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu reassigned HIVE-1982:
----------------------------

    Assignee:     (was: Ted Xu)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Attachment:     (was: HIVE-1982-v1.patch)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Attachment: HIVE-1982-v2.patch

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-v1.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1982:
-------------------------------

    Status: Open  (was: Patch Available)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Attachment: HIVE-1982-v1.patch

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-v1.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12998204#comment-12998204 ] 

He Yongqiang commented on HIVE-1982:
------------------------------------

Ted, can you update your patch based on the trunk? (probably just need to regenerate some output files)
sorry, after 1517 committed, the patch can not be applied cleanly.

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12993210#comment-12993210 ] 

He Yongqiang commented on HIVE-1982:
------------------------------------

can you move the new code out of the for loop? And also pls confirm that mysql has the same semantic here. Otherwise, we need to fix the underlying problem.

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12997645#comment-12997645 ] 

He Yongqiang commented on HIVE-1982:
------------------------------------

+1

will commit after tests pass. Thanks Ted!

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "He Yongqiang (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

He Yongqiang updated HIVE-1982:
-------------------------------

    Status: Open  (was: Patch Available)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Attachment: HIVE-1982.patch

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Status: Patch Available  (was: Open)

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Updated: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Xu updated HIVE-1982:
-------------------------

    Attachment: HIVE-1982-3.patch

Thanks Yongqiang. I traced the problem again, and it turned out quit simple. The error was introduced by RowResolver not handled well in  ReduceSinkOperator.
Please review the patch again, thanks.

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982-3.patch, HIVE-1982-v2.patch, HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] Commented: (HIVE-1982) Group by key shall not duplicate with distinct key

Posted by "Ted Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HIVE-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12994261#comment-12994261 ] 

Ted Xu commented on HIVE-1982:
------------------------------

Thanks Yongqiang. The patch just disables it by throws an exception when the case happens.
It is true that MySQL support such semantic, but MySQL also support other weird semantics like duplicated group by keys.  

> Group by key shall not duplicate with distinct key
> --------------------------------------------------
>
>                 Key: HIVE-1982
>                 URL: https://issues.apache.org/jira/browse/HIVE-1982
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 0.6.0, 0.7.0
>            Reporter: Ted Xu
>            Assignee: Ted Xu
>            Priority: Minor
>         Attachments: HIVE-1982.patch
>
>
> Group by key shall not duplicate with distinct key, or there will be error because RowResolver and ColumnInfo didn't match.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira