You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Robbie Gemmell (JIRA)" <ji...@apache.org> on 2012/11/18 19:18:57 UTC
[jira] [Created] (QPID-4441) [Java broker] queue declare arguments
are lost during v6 schema update for the optional bdbstore
Robbie Gemmell created QPID-4441:
------------------------------------
Summary: [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
Key: QPID-4441
URL: https://issues.apache.org/jira/browse/QPID-4441
Project: Qpid
Issue Type: Bug
Components: Java Broker
Affects Versions: 0.18
Reporter: Robbie Gemmell
Assignee: Robbie Gemmell
Priority: Blocker
Fix For: 0.19
The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Resolved] (QPID-4441) [Java broker] queue declare arguments
are lost during v6 schema update for the optional bdbstore
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alex Rudyy resolved QPID-4441.
------------------------------
Resolution: Fixed
I reviewed all the changes and Robbie and I worked together on improving the BDB store upgrade tests to cover the upgrade cases affected by the issue.
The changes to the tests have been committed in the revision http://svn.apache.org/viewvc?view=revision&revision=1412203
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505392#comment-13505392 ]
Justin Ross commented on QPID-4441:
-----------------------------------
Reviewed by Alex. Approved for 0.20.
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Alex Rudyy (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509671#comment-13509671 ]
Alex Rudyy commented on QPID-4441:
----------------------------------
The new tests introduced in revision 1415127 look good for me. As the revision introduces only tests it is safe to commit them into 0.20 release branch.
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Updated] (QPID-4441) [Java broker] queue declare arguments
are lost during v6 schema update for the optional bdbstore
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Justin Ross updated QPID-4441:
------------------------------
Fix Version/s: 0.20
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Justin Ross (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13509674#comment-13509674 ]
Justin Ross commented on QPID-4441:
-----------------------------------
New tests reviewed by Alex and approved for 0.20.
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13505769#comment-13505769 ]
Robbie Gemmell commented on QPID-4441:
--------------------------------------
The additional test changes have now been merged to the 0.20 release branch.
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499865#comment-13499865 ]
Robbie Gemmell commented on QPID-4441:
--------------------------------------
Committed a fix for the underlying FieldTable#addAll(..) defect: http://svn.apache.org/viewvc?view=revision&revision=1410949
Still need to add unit tests to the bdbstore UpgradeFrom5to6Test to verify its effectiveness (requires first updating the v4 and v5 store schema test data).
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Comment Edited] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13499865#comment-13499865 ]
Robbie Gemmell edited comment on QPID-4441 at 11/18/12 6:25 PM:
----------------------------------------------------------------
Committed a test and fix for the underlying FieldTable#addAll(..) defect: http://svn.apache.org/viewvc?view=revision&revision=1410949
Still need to add unit tests to the bdbstore UpgradeFrom5to6Test to verify its effectiveness (requires first updating the v4 and v5 store schema test data).
was (Author: gemmellr):
Committed a fix for the underlying FieldTable#addAll(..) defect: http://svn.apache.org/viewvc?view=revision&revision=1410949
Still need to add unit tests to the bdbstore UpgradeFrom5to6Test to verify its effectiveness (requires first updating the v4 and v5 store schema test data).
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org
[jira] [Commented] (QPID-4441) [Java broker] queue declare
arguments are lost during v6 schema update for the optional bdbstore
Posted by "Robbie Gemmell (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/QPID-4441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13506461#comment-13506461 ]
Robbie Gemmell commented on QPID-4441:
--------------------------------------
Another test-only change, adding some new systests:
http://svn.apache.org/viewvc?rev=1415127&view=rev
> [Java broker] queue declare arguments are lost during v6 schema update for the optional bdbstore
> ------------------------------------------------------------------------------------------------
>
> Key: QPID-4441
> URL: https://issues.apache.org/jira/browse/QPID-4441
> Project: Qpid
> Issue Type: Bug
> Components: Java Broker
> Affects Versions: 0.18
> Reporter: Robbie Gemmell
> Assignee: Robbie Gemmell
> Priority: Blocker
> Fix For: 0.19, 0.20
>
>
> The queue declare arguments are lost during v5 -> v6 store schema update for the optional bdbstore. This will present itself in a variety of ways, such as a DLQ losing the marker argument used to prevent chained DLQ creation, and also in Priority and Sorted queues becoming regular queues.
> As part of the schema update, the old FieldTable binary encoding for the queue arguments is transitioned to a property within the larger JSON ConfiguredObject encoding. This process makes use of an intermediate FieldTable to which it does an addAll() based copy of the original FieldTable and then potentially adds a new description argument. This addAll() fails to copy the previous properties due to a defect in the method, wherby the source FieldTables lack of use after creation from encoded bytes means they have yet to be decoded and this is in effect mistaken as it being an empty FieldTable.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org