You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@subversion.apache.org by Hyrum K Wright <hy...@wandisco.com> on 2012/04/27 15:35:13 UTC

Re: svn commit: r1331242 - in /subversion/trunk/subversion: include/svn_error.h libsvn_subr/error.c

On Fri, Apr 27, 2012 at 1:32 AM,  <gs...@apache.org> wrote:
> Author: gstein
> Date: Fri Apr 27 06:32:40 2012
> New Revision: 1331242
>
> URL: http://svn.apache.org/viewvc?rev=1331242&view=rev
> Log:
> Fix error tracing to record file/line properly.
>
> When code said:
>  return svn_error_trace(foo());
>
> It would set the file/line for that location, then call foo() and wrap
> any resulting error. However, foo() could potentially set its own
> file/line for an inner error. This revision uses a helper function to
> reorder execution to: call foo(), then set file/line, then wrap any
> resulting error with the trace information.
>
> Prior symptoms were duplicate file/line. They are resolved properly now.

Yay!  This has been one of the rather annoying bits of the error
tracing system, that I've never quite been able to track down.  Thanks
for fixing it.

-Hyrum


-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/