You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by GitBox <gi...@apache.org> on 2021/06/24 21:35:17 UTC
[GitHub] [mesos] surahman opened a new pull request #396: [contibutors] add yaml entry.
surahman opened a new pull request #396:
URL: https://github.com/apache/mesos/pull/396
@qianzhangxa I have added my mapping information to the contributor file, thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] asfgit closed pull request #396: [contibutors] add yaml entry.
Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #396:
URL: https://github.com/apache/mesos/pull/396
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] qianzhangxa commented on a change in pull request #396: [contibutors] add yaml entry.
Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on a change in pull request #396:
URL: https://github.com/apache/mesos/pull/396#discussion_r658790327
##########
File path: docs/contributors.yaml
##########
@@ -963,3 +963,9 @@
- bluezhudong@gmail.com
jira_user: dzhu
reviewboard_user: dzhu
+
+- name: Saad Ur Rahman
+ emails:
+ - saad.ur.rahman@gmail.com
+ jira_user: surahman
+ reviewboard_user: saad.ur.rahman
Review comment:
@surahman No problem, I have merged it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] surahman commented on a change in pull request #396: [contibutors] add yaml entry.
Posted by GitBox <gi...@apache.org>.
surahman commented on a change in pull request #396:
URL: https://github.com/apache/mesos/pull/396#discussion_r658796403
##########
File path: docs/contributors.yaml
##########
@@ -963,3 +963,9 @@
- bluezhudong@gmail.com
jira_user: dzhu
reviewboard_user: dzhu
+
+- name: Saad Ur Rahman
+ emails:
+ - saad.ur.rahman@gmail.com
+ jira_user: surahman
+ reviewboard_user: saad.ur.rahman
Review comment:
@qianzhangxa thanks :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] qianzhangxa commented on a change in pull request #396: [contibutors] add yaml entry.
Posted by GitBox <gi...@apache.org>.
qianzhangxa commented on a change in pull request #396:
URL: https://github.com/apache/mesos/pull/396#discussion_r658771550
##########
File path: docs/contributors.yaml
##########
@@ -963,3 +963,9 @@
- bluezhudong@gmail.com
jira_user: dzhu
reviewboard_user: dzhu
+
+- name: Saad Ur Rahman
+ emails:
+ - saad.ur.rahman@gmail.com
+ jira_user: surahman
+ reviewboard_user: saad.ur.rahman
Review comment:
This file is in alphabetical order, so I do not think your info should be added in the bottom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mesos] surahman commented on a change in pull request #396: [contibutors] add yaml entry.
Posted by GitBox <gi...@apache.org>.
surahman commented on a change in pull request #396:
URL: https://github.com/apache/mesos/pull/396#discussion_r658781861
##########
File path: docs/contributors.yaml
##########
@@ -963,3 +963,9 @@
- bluezhudong@gmail.com
jira_user: dzhu
reviewboard_user: dzhu
+
+- name: Saad Ur Rahman
+ emails:
+ - saad.ur.rahman@gmail.com
+ jira_user: surahman
+ reviewboard_user: saad.ur.rahman
Review comment:
@qianzhangxa sorry about that, I very quickly tail appended the data 🤦🏽. I have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@mesos.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org