You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@calcite.apache.org by "Stamatis Zampetakis (Jira)" <ji...@apache.org> on 2021/11/16 11:34:00 UTC
[jira] [Commented] (CALCITE-4884) Provide a new constructor for RelJsonWriter to allow customized JsonBuilder
[ https://issues.apache.org/jira/browse/CALCITE-4884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17444490#comment-17444490 ]
Stamatis Zampetakis commented on CALCITE-4884:
----------------------------------------------
Hey [~Chunwei Lei], it would be nice to provide some examples of what customization you would like to achieve. Adding a new API without any hints or tests on how to use makes it difficult to take advantage of it.
> Provide a new constructor for RelJsonWriter to allow customized JsonBuilder
> ---------------------------------------------------------------------------
>
> Key: CALCITE-4884
> URL: https://issues.apache.org/jira/browse/CALCITE-4884
> Project: Calcite
> Issue Type: Improvement
> Reporter: Chunwei Lei
> Assignee: Chunwei Lei
> Priority: Major
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently JsonBuilder in RelJsonWriter cannot be customized due to it being created in the constructor. We can provide a new constructor for RelJsonWriter to allow customized JsonBuilder.
> {code:java}
> // code placeholder
> public RelJsonWriter() {
> jsonBuilder = new JsonBuilder();
> relList = jsonBuilder.list();
> relJson = new RelJson(jsonBuilder);
> }
> // the new constrctor suggested.
> public RelJsonWriter(JsonBuilder jsonBuilder) {
> this.jsonBuilder = jsonBuilder;
> relList = jsonBuilder.list();
> relJson = new RelJson(jsonBuilder);
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.1#820001)