You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by jb...@apache.org on 2020/12/19 06:27:00 UTC

[karaf] branch master updated: [KARAF-6957] Add Spring 5.3.x support

This is an automated email from the ASF dual-hosted git repository.

jbonofre pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/karaf.git


The following commit(s) were added to refs/heads/master by this push:
     new 81381a1  [KARAF-6957] Add Spring 5.3.x support
     new a287861  Merge pull request #1268 from jbonofre/KARAF-6957
81381a1 is described below

commit 81381a1c5f99021fdae40ed71c77433d2a16f2ad
Author: jbonofre <jb...@apache.org>
AuthorDate: Tue Dec 15 17:45:10 2020 +0100

    [KARAF-6957] Add Spring 5.3.x support
---
 .../spring-legacy/src/main/feature/feature.xml     | 76 ++++++++++++++++++++
 .../features/spring/src/main/feature/feature.xml   | 84 +++++++++++-----------
 itests/test/pom.xml                                |  2 +
 .../java/org/apache/karaf/itests/BaseTest.java     |  1 +
 .../itests/features/Spring52FeaturesTest.java      | 22 ++++++
 ...FeaturesTest.java => Spring53FeaturesTest.java} | 33 ++++-----
 pom.xml                                            |  1 +
 7 files changed, 157 insertions(+), 62 deletions(-)

diff --git a/assemblies/features/spring-legacy/src/main/feature/feature.xml b/assemblies/features/spring-legacy/src/main/feature/feature.xml
index 433f735..f5790af 100644
--- a/assemblies/features/spring-legacy/src/main/feature/feature.xml
+++ b/assemblies/features/spring-legacy/src/main/feature/feature.xml
@@ -209,6 +209,82 @@
         <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-websocket/${spring43.version}</bundle>
     </feature>
 
+    <!-- Spring 5.2.x support -->
+
+    <feature name="spring" description="Spring 5.2.x support" version="${spring52.version}">
+        <bundle dependency="true" start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.aopalliance/${aopalliance.bundle.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-core/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-expression/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-beans/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aop/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context-support/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-aspects" description="Spring 5.2.x AOP support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aspects/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-instrument" description="Spring 5.2.x Instrument support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-instrument/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-jdbc" description="Spring 5.2.x JDBC support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring-tx</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jdbc/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-jms" description="Spring 5.2.x JMS support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring-tx</feature>
+        <bundle dependency="true" start-level="10">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${geronimo.jta-spec.version}</bundle>
+        <bundle dependency="true" start-level="10">mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${geronimo.jms-spec.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jms/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-messaging" description="Spring 5.2.x Messaging support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-messaging/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-test" description="Spring 5.2.x Test support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle dependency="true">mvn:javax.websocket/javax.websocket-api/1.1</bundle>
+        <bundle dependency="true">mvn:org.apache.httpcomponents/httpcore-osgi/4.4.6</bundle>
+        <bundle dependency="true">mvn:org.apache.httpcomponents/httpclient-osgi/4.5.2</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-test/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-orm" description="Spring 5.2.x ORM support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring-jdbc</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-orm/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-oxm" description="Spring 5.2.x OXM support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-oxm/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-tx" description="Spring 5.2.x Transaction (TX) support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-tx/${spring52.version}</bundle>
+    </feature>
+
+    <feature name="spring-web" description="Spring 5.2.x Web support" version="${spring52.version}">
+        <feature version="[${spring52.version},5.3)">spring</feature>
+        <bundle dependency="true">mvn:javax.servlet/javax.servlet-api/3.1.0</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-web/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-webmvc/${spring52.version}</bundle>
+        <requirement>osgi.implementation;osgi.implementation="osgi.http";version:Version="1.1"</requirement>
+    </feature>
+
+    <feature name="spring-websocket" description="Spring 5.2.x WebSocket support" version="${spring52.version}">
+        <bundle dependency="true">mvn:javax.websocket/javax.websocket-api/1.1</bundle>
+        <feature version="[${spring52.version},5.3)">spring-web</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-websocket/${spring52.version}</bundle>
+    </feature>
+
     <!-- Spring Security support -->
 
     <feature name="spring-security" description="Spring Security 3.1.x support" version="${spring.security31.version}">
diff --git a/assemblies/features/spring/src/main/feature/feature.xml b/assemblies/features/spring/src/main/feature/feature.xml
index 084710a..33009d3 100644
--- a/assemblies/features/spring/src/main/feature/feature.xml
+++ b/assemblies/features/spring/src/main/feature/feature.xml
@@ -22,80 +22,80 @@
 
     <repository>mvn:org.apache.karaf.features/standard/${project.version}/xml/features</repository>
 
-    <!-- Spring 5.2.x support -->
+    <!-- Spring 5.3.x support -->
 
-    <feature name="spring" description="Spring 5.2.x support" version="${spring52.version}">
+    <feature name="spring" description="Spring 5.3.x support" version="${spring53.version}">
         <bundle dependency="true" start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.aopalliance/${aopalliance.bundle.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-core/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-expression/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-beans/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aop/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context-support/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-core/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-expression/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-beans/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aop/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-context-support/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-aspects" description="Spring 5.2.x AOP support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aspects/${spring52.version}</bundle>
+    <feature name="spring-aspects" description="Spring 5.3.x AOP support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-aspects/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-instrument" description="Spring 5.2.x Instrument support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-instrument/${spring52.version}</bundle>
+    <feature name="spring-instrument" description="Spring 5.3.x Instrument support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-instrument/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-jdbc" description="Spring 5.2.x JDBC support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring-tx</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jdbc/${spring52.version}</bundle>
+    <feature name="spring-jdbc" description="Spring 5.3.x JDBC support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring-tx</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jdbc/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-jms" description="Spring 5.2.x JMS support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring-tx</feature>
+    <feature name="spring-jms" description="Spring 5.3.x JMS support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring-tx</feature>
         <bundle dependency="true" start-level="10">mvn:org.apache.geronimo.specs/geronimo-jta_1.1_spec/${geronimo.jta-spec.version}</bundle>
         <bundle dependency="true" start-level="10">mvn:org.apache.geronimo.specs/geronimo-jms_1.1_spec/${geronimo.jms-spec.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jms/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-jms/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-messaging" description="Spring 5.2.x Messaging support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-messaging/${spring52.version}</bundle>
+    <feature name="spring-messaging" description="Spring 5.3.x Messaging support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-messaging/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-test" description="Spring 5.2.x Test support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
+    <feature name="spring-test" description="Spring 5.3.x Test support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
         <bundle dependency="true">mvn:javax.websocket/javax.websocket-api/1.1</bundle>
         <bundle dependency="true">mvn:org.apache.httpcomponents/httpcore-osgi/4.4.6</bundle>
         <bundle dependency="true">mvn:org.apache.httpcomponents/httpclient-osgi/4.5.2</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-test/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-test/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-orm" description="Spring 5.2.x ORM support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring-jdbc</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-orm/${spring52.version}</bundle>
+    <feature name="spring-orm" description="Spring 5.3.x ORM support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring-jdbc</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-orm/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-oxm" description="Spring 5.2.x OXM support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-oxm/${spring52.version}</bundle>
+    <feature name="spring-oxm" description="Spring 5.3.x OXM support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-oxm/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-tx" description="Spring 5.2.x Transaction (TX) support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-tx/${spring52.version}</bundle>
+    <feature name="spring-tx" description="Spring 5.3.x Transaction (TX) support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-tx/${spring53.version}</bundle>
     </feature>
 
-    <feature name="spring-web" description="Spring 5.2.x Web support" version="${spring52.version}">
-        <feature version="[${spring52.version},5.3)">spring</feature>
+    <feature name="spring-web" description="Spring 5.3.x Web support" version="${spring53.version}">
+        <feature version="[${spring53.version},5.4)">spring</feature>
         <bundle dependency="true">mvn:javax.servlet/javax.servlet-api/3.1.0</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-web/${spring52.version}</bundle>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-webmvc/${spring52.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-web/${spring53.version}</bundle>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-webmvc/${spring53.version}</bundle>
         <requirement>osgi.implementation;osgi.implementation="osgi.http";version:Version="1.1"</requirement>
     </feature>
 
-    <feature name="spring-websocket" description="Spring 5.2.x WebSocket support" version="${spring52.version}">
+    <feature name="spring-websocket" description="Spring 5.3.x WebSocket support" version="${spring53.version}">
         <bundle dependency="true">mvn:javax.websocket/javax.websocket-api/1.1</bundle>
-        <feature version="[${spring52.version},5.3)">spring-web</feature>
-        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-websocket/${spring52.version}</bundle>
+        <feature version="[${spring53.version},5.4)">spring-web</feature>
+        <bundle start-level="30">mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.spring-websocket/${spring53.version}</bundle>
     </feature>
 
     <!-- Spring Security -->
diff --git a/itests/test/pom.xml b/itests/test/pom.xml
index c92a9fa..6b3ccf7 100644
--- a/itests/test/pom.xml
+++ b/itests/test/pom.xml
@@ -321,6 +321,7 @@
                         <spring31.version>${spring31.version}</spring31.version>
                         <spring43.version>${spring43.version}</spring43.version>
                         <spring52.version>${spring52.version}</spring52.version>
+                        <spring53.version>${spring53.version}</spring53.version>
                         <spring.security31.version>${spring.security31.version}</spring.security31.version>
                         <spring.security42.version>${spring.security42.version}</spring.security42.version>
                         <spring.security53.version>${spring.security53.version}</spring.security53.version>
@@ -378,6 +379,7 @@
                                 <spring31.version>${spring31.version}</spring31.version>
                                 <spring43.version>${spring43.version}</spring43.version>
                                 <spring52.version>${spring52.version}</spring52.version>
+                                <spring53.version>${spring53.version}</spring53.version>
                                 <spring.security31.version>${spring.security31.version}</spring.security31.version>
                                 <spring.security42.version>${spring.security42.version}</spring.security42.version>
                                 <spring.security53.version>${spring.security53.version}</spring.security53.version>
diff --git a/itests/test/src/test/java/org/apache/karaf/itests/BaseTest.java b/itests/test/src/test/java/org/apache/karaf/itests/BaseTest.java
index e972133..18db2af 100644
--- a/itests/test/src/test/java/org/apache/karaf/itests/BaseTest.java
+++ b/itests/test/src/test/java/org/apache/karaf/itests/BaseTest.java
@@ -28,6 +28,7 @@ public class BaseTest extends KarafTestSupport {
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring31.version", System.getProperty("spring31.version")),
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring43.version", System.getProperty("spring43.version")),
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring52.version", System.getProperty("spring52.version")),
+                KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring53.version", System.getProperty("spring53.version")),
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring.security31.version", System.getProperty("spring.security31.version")),
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring.security42.version", System.getProperty("spring.security42.version")),
                 KarafDistributionOption.editConfigurationFilePut("etc/system.properties", "spring.security53.version", System.getProperty("spring.security53.version")),
diff --git a/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java b/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java
index fe300ba..37ea239 100644
--- a/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java
+++ b/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java
@@ -16,14 +16,36 @@ package org.apache.karaf.itests.features;
 import org.apache.karaf.itests.BaseTest;
 import org.junit.Test;
 import org.junit.runner.RunWith;
+import org.ops4j.pax.exam.Configuration;
+import org.ops4j.pax.exam.MavenUtils;
+import org.ops4j.pax.exam.Option;
 import org.ops4j.pax.exam.junit.PaxExam;
 import org.ops4j.pax.exam.spi.reactors.ExamReactorStrategy;
 import org.ops4j.pax.exam.spi.reactors.PerClass;
 
+import java.util.Arrays;
+import java.util.LinkedList;
+import java.util.List;
+
+import static org.ops4j.pax.exam.karaf.options.KarafDistributionOption.editConfigurationFilePut;
+
 @RunWith(PaxExam.class)
 @ExamReactorStrategy(PerClass.class)
 public class Spring52FeaturesTest extends BaseTest {
 
+    @Configuration
+    public Option[] config() {
+        String version = MavenUtils.getArtifactVersion("org.apache.karaf", "apache-karaf");
+        List<Option> result = new LinkedList<>(Arrays.asList(super.config()));
+        result.add(editConfigurationFilePut("etc/org.apache.karaf.features.cfg", "featuresRepositories",
+                "mvn:org.apache.karaf.features/framework/" + version + "/xml/features, " +
+                        "mvn:org.apache.karaf.features/spring/" + version + "/xml/features, " +
+                        "mvn:org.apache.karaf.features/spring-legacy/" + version + "/xml/features, " +
+                        "mvn:org.apache.karaf.features/enterprise/" + version + "/xml/features, " +
+                        "mvn:org.apache.karaf.features/standard/" + version + "/xml/features"));
+        return result.toArray(new Option[result.size()]);
+    }
+
     @Test
     public void installSpringFeature() throws Exception {
         installAssertAndUninstallFeature("spring", System.getProperty("spring52.version"));
diff --git a/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java b/itests/test/src/test/java/org/apache/karaf/itests/features/Spring53FeaturesTest.java
similarity index 79%
copy from itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java
copy to itests/test/src/test/java/org/apache/karaf/itests/features/Spring53FeaturesTest.java
index fe300ba..017254c 100644
--- a/itests/test/src/test/java/org/apache/karaf/itests/features/Spring52FeaturesTest.java
+++ b/itests/test/src/test/java/org/apache/karaf/itests/features/Spring53FeaturesTest.java
@@ -22,74 +22,67 @@ import org.ops4j.pax.exam.spi.reactors.PerClass;
 
 @RunWith(PaxExam.class)
 @ExamReactorStrategy(PerClass.class)
-public class Spring52FeaturesTest extends BaseTest {
+public class Spring53FeaturesTest extends BaseTest {
 
     @Test
     public void installSpringFeature() throws Exception {
-        installAssertAndUninstallFeature("spring", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringAspectsFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-aspects", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-aspects", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringInstrumentFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-instrument", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-instrument", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringJdbcFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-jdbc", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-jdbc", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringJmsFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-jms", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-jms", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringMessagingFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-messaging", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-messaging", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringTestFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-test", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-test", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringOrmFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-orm", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-orm", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringOxmFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-oxm", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-oxm", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringTxFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-tx", System.getProperty("spring52.version"));
+        installAssertAndUninstallFeature("spring-tx", System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringWebFeature() throws Exception {
-        installAssertAndUninstallFeatures("pax-web-http", "spring-web/" + System.getProperty("spring52.version"));
+        installAssertAndUninstallFeatures("pax-web-http", "spring-web/" + System.getProperty("spring53.version"));
     }
 
     @Test
     public void installSpringWebSocketFeature() throws Exception {
         installAndAssertFeature("pax-web-http");
-        installAssertAndUninstallFeatures("pax-web-http", "spring-websocket/" + System.getProperty("spring52.version"));
-    }
-
-    // Spring Security
-
-    @Test
-    public void installSpringSecurityFeature() throws Exception {
-        installAssertAndUninstallFeature("spring-security", System.getProperty("spring.security53.version"));
+        installAssertAndUninstallFeatures("pax-web-http", "spring-websocket/" + System.getProperty("spring53.version"));
     }
 
 }
diff --git a/pom.xml b/pom.xml
index a542e8a..a727c82 100644
--- a/pom.xml
+++ b/pom.xml
@@ -287,6 +287,7 @@
         <spring31.version>3.1.4.RELEASE</spring31.version>
         <spring43.version>4.3.29.RELEASE_1</spring43.version>
         <spring52.version>5.2.9.RELEASE_2</spring52.version>
+        <spring53.version>5.3.1_1</spring53.version>
         <spring.security31.version>3.1.4.RELEASE</spring.security31.version>
         <spring.security42.version>4.2.4.RELEASE_1</spring.security42.version>
         <spring.security51.version>5.1.5.RELEASE_1</spring.security51.version>