[GitHub] [ozone] JyotinderSingh commented on a diff in pull request #3277: HDDS-6545. OzoneManagerUtils#getBucketLayout should not suppress bucket key lookup errors.

[GitBox <gi...@apache.org>]

JyotinderSingh commented on code in PR #3277:
URL: https://github.com/apache/ozone/pull/3277#discussion_r844837533


##########
hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/KeyManagerImpl.java:
##########
@@ -338,8 +338,8 @@ public OmKeyInfo lookupKey(OmKeyArgs args, String clientAddress)
         bucketName);
 
     BucketLayout bucketLayout =
-        getBucketLayout(metadataManager, args.getVolumeName(),
-            args.getBucketName());
+        OzoneManagerUtils.getBucketLayout(args.getVolumeName(),
+            args.getBucketName(), ozoneManager, new HashSet<>());

Review Comment:
   Thanks a lot for the reviews @adoroszlai, I have addressed these points in my latest patch.
   I had a typo in one place which seemed to be causing the CI errors, waiting on the new run to verify the behavior now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org