You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by ro...@apache.org on 2017/04/20 15:55:21 UTC
[3/6] beam git commit: Remove obsolete and unused Runner.clear
Remove obsolete and unused Runner.clear
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/4b9029ac
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/4b9029ac
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/4b9029ac
Branch: refs/heads/master
Commit: 4b9029ac3e965ed3629833138597f1fb365b0876
Parents: 68c0042
Author: Robert Bradshaw <ro...@gmail.com>
Authored: Tue Apr 11 10:57:35 2017 -0700
Committer: Robert Bradshaw <ro...@gmail.com>
Committed: Thu Apr 20 08:55:04 2017 -0700
----------------------------------------------------------------------
sdks/python/apache_beam/runners/runner.py | 34 --------------------------
1 file changed, 34 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/4b9029ac/sdks/python/apache_beam/runners/runner.py
----------------------------------------------------------------------
diff --git a/sdks/python/apache_beam/runners/runner.py b/sdks/python/apache_beam/runners/runner.py
index ccb066b..b35cb7b 100644
--- a/sdks/python/apache_beam/runners/runner.py
+++ b/sdks/python/apache_beam/runners/runner.py
@@ -99,8 +99,6 @@ class PipelineRunner(object):
The base runner provides a run() method for visiting every node in the
pipeline's DAG and executing the transforms computing the PValue in the node.
- It also provides a clear() method for visiting every node and clearing out
- the values contained in PValue objects produced during a run.
A custom runner will typically provide implementations for some of the
transform methods (ParDo, GroupByKey, Create, etc.). It may also
@@ -129,38 +127,6 @@ class PipelineRunner(object):
pipeline.visit(RunVisitor(self))
- def clear(self, pipeline, node=None):
- """Clear all nodes or nodes reachable from node of materialized values.
-
- Args:
- pipeline: Pipeline object containing PValues to be cleared.
- node: Optional node in the Pipeline processing DAG. If specified only
- nodes reachable from this node will be cleared (ancestors of the node).
-
- This method is not intended (for now) to be called by users of Runner
- objects. It is a hook for future layers on top of the current programming
- model to control how much of the previously computed values are kept
- around. Presumably an interactivity layer will use it. The simplest way
- to change the behavior would be to define a runner that overwrites the
- clear_pvalue() method since this method (runner.clear) will visit all
- relevant nodes and call clear_pvalue on them.
-
- """
-
- # Imported here to avoid circular dependencies.
- # pylint: disable=wrong-import-order, wrong-import-position
- from apache_beam.pipeline import PipelineVisitor
-
- class ClearVisitor(PipelineVisitor):
-
- def __init__(self, runner):
- self.runner = runner
-
- def visit_value(self, value, _):
- self.runner.clear_pvalue(value)
-
- pipeline.visit(ClearVisitor(self), node=node)
-
def apply(self, transform, input):
"""Runner callback for a pipeline.apply call.