You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kvrocks.apache.org by "git-hulk (via GitHub)" <gi...@apache.org> on 2023/04/29 12:31:01 UTC

[GitHub] [incubator-kvrocks] git-hulk opened a new issue, #1411: Check if the cluster mode is consistent between master and slaves when replication

git-hulk opened a new issue, #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-kvrocks/issues) and found no similar issues.
   
   
   ### Motivation
   
   Currently, we didn't check the cluster status between the master and slaves, and the slave may crash if the master enabled the cluster node but not enabled in slaves, and vice versa.
   
   ### Solution
   
   Check the cluster status when replication.
   
   ### Are you willing to submit a PR?
   
   - [X] I'm willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1411: Check if the cluster mode is consistent between master and slaves when replication

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411#issuecomment-1599893488

   Hi @uds5501 Thanks for your attention.
   
   Like Redis, Kvrocks can run in the master-replica or cluster mode(by enabling the cluster-enabled in kvrocks.conf), we would like to check if it configured the cluster mode consistently when setup the replication.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] uds5501 commented on issue #1411: Check if the cluster mode is consistent between master and slaves when replication

Posted by "uds5501 (via GitHub)" <gi...@apache.org>.
uds5501 commented on issue #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411#issuecomment-1599144053

   What are the deliverables / check points for this task? I can think of 2 broad ones :
   - When trying to toggling cluster mode on or off in master / slave, verify if both are on same mode or not, if not then maybe master can propogate the cluster mode `on` to slave as well (additional thoughts: this may break the cluster configs in other nodes of the cluster as they will be unaware of this new slave)
   
   - When a master node is part of the cluster and a new instance is going to replicate this master, then it needs to be configured in such a way that it's part of the cluster as well.
   
   LMK if I misunderstood these deliverables. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] git-hulk commented on issue #1411: Check if the cluster mode is consistent between master and slaves when replication

Posted by "git-hulk (via GitHub)" <gi...@apache.org>.
git-hulk commented on issue #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411#issuecomment-1528901065

   Yes, it needs to add the cluster status into the replication process without breaking changes, so I assigned it to myself.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] zevin02 commented on issue #1411: Check if the cluster mode is consistent between master and slaves when replication

Posted by "zevin02 (via GitHub)" <gi...@apache.org>.
zevin02 commented on issue #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411#issuecomment-1528799590

   please assign to me


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-kvrocks] PragmaTwice commented on issue #1411: Check if the cluster mode is consistent between master and slaves when replication

Posted by "PragmaTwice (via GitHub)" <gi...@apache.org>.
PragmaTwice commented on issue #1411:
URL: https://github.com/apache/incubator-kvrocks/issues/1411#issuecomment-1528821195

   > please assign to me
   
   @git-hulk is self-assigned now, so it may not available for you.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org