You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/08/05 17:00:45 UTC

[GitHub] [incubator-mxnet] ys2843 opened a new pull request #18863: improve python api website ux - make toc sticky

ys2843 opened a new pull request #18863:
URL: https://github.com/apache/incubator-mxnet/pull/18863


   ## Description ##
   Make the table of content widget on Python docs site `sticky` so that it won't be cut off by the footer when scrolling down to the bottom. @ChaiBapchya 
   
   Current TOC:
   
   <img width="1440" alt="Screen Shot 2020-08-05 at 9 53 21 AM" src="https://user-images.githubusercontent.com/23468760/89441241-b338ba80-d701-11ea-8471-1d27d4bf3f09.png">
   
   New sticky TOC:
   
   <img width="1440" alt="Screen Shot 2020-08-05 at 9 55 49 AM" src="https://user-images.githubusercontent.com/23468760/89441410-f5fa9280-d701-11ea-8728-1af1301230e6.png">
   
   ### Changes ###
   - [ ] Make TOC widget sticky
   - [ ] Fixed general version dropdown style breaks in Safari by adding height to the caret
   
   ## Comments ##
   - Preview: http://ec2-18-236-134-13.us-west-2.compute.amazonaws.com/api/python/docs/tutorials/getting-started/crash-course/1-ndarray.html
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] sandeep-krishnamurthy merged pull request #18863: improve python api website ux - make toc sticky

Posted by GitBox <gi...@apache.org>.
sandeep-krishnamurthy merged pull request #18863:
URL: https://github.com/apache/incubator-mxnet/pull/18863


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #18863: improve python api website ux - make toc sticky

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #18863:
URL: https://github.com/apache/incubator-mxnet/pull/18863#issuecomment-669311912


   Hey @ys2843 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [windows-cpu, website, unix-cpu, sanity, edge, clang, unix-gpu, windows-gpu, centos-cpu, miscellaneous, centos-gpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ChaiBapchya commented on pull request #18863: improve python api website ux - make toc sticky

Posted by GitBox <gi...@apache.org>.
ChaiBapchya commented on pull request #18863:
URL: https://github.com/apache/incubator-mxnet/pull/18863#issuecomment-669510525


   @mxnet-label-bot add [pr-awaiting-merge]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] ys2843 commented on pull request #18863: improve python api website ux - make toc sticky

Posted by GitBox <gi...@apache.org>.
ys2843 commented on pull request #18863:
URL: https://github.com/apache/incubator-mxnet/pull/18863#issuecomment-669312287


   @mxnet-label-bot add [Website]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org