You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2019/11/18 21:28:25 UTC

[GitHub] [hadoop-ozone] mbsharp commented on issue #193: HDDS-2512 Sonar TraceAllMethod NPE Could be Thrown

mbsharp commented on issue #193: HDDS-2512 Sonar TraceAllMethod NPE Could be Thrown
URL: https://github.com/apache/hadoop-ozone/pull/193#issuecomment-555217318
 
 
   After further review, I do agree throwing an exception would be better here.  With that, I moved the null check up to just after the findDelegatedMethod call and included the method name for the detail.  I am open to the wording if we want to change that, but at least it gives some context now.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org